Skip to content

clean up the ValidateSaleTransaction function parameters #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Oct 28, 2026
Merged

clean up the ValidateSaleTransaction function parameters #1990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 13 additions & 39 deletions TransactionProcessor.BusinessLogic.Tests/Services/TransactionDomainServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ public async Task TransactionDomainService_ProcessLogonTransaction_DeviceNeedsAd
this.AggregateService.GetLatest<MerchantAggregate>(Arg<Guid>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success(TestData.Aggregates.CreatedMerchantAggregate()));

this.TransactionValidationService.ValidateLogonTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateLogonTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.SuccessNeedToAddDevice, "SUCCESS")));

TransactionCommands.ProcessLogonTransactionCommand command = new(TestData.TransactionId,
Expand Down Expand Up @@ -117,9 +115,7 @@ public async Task TransactionDomainService_ProcessLogonTransaction_TransactionIs
this.AggregateService.Save(Arg<TransactionAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success());

this.TransactionValidationService.ValidateLogonTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateLogonTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.Success, "SUCCESS")));

TransactionCommands.ProcessLogonTransactionCommand command = new(TestData.TransactionId,
Expand Down Expand Up @@ -148,9 +144,7 @@ public async Task TransactionDomainService_ProcessLogonTransaction_ValidationFai
.ReturnsAsync(Result.Success(TestData.GetEmptyTransactionAggregate()));
this.AggregateService.Save(Arg<TransactionAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success());
this.TransactionValidationService.ValidateLogonTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateLogonTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(responseCode, responseCode.ToString())));

TransactionCommands.ProcessLogonTransactionCommand command = new(TestData.TransactionId,
Expand All @@ -176,9 +170,7 @@ public async Task TransactionDomainService_ProcessReconciliationTransaction_Reco
.ReturnsAsync(new ReconciliationAggregate());
this.AggregateService.Save(Arg<ReconciliationAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success());
this.TransactionValidationService.ValidateReconciliationTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateReconciliationTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.Success, "SUCCESS")));

TransactionCommands.ProcessReconciliationCommand command =
Expand Down Expand Up @@ -206,9 +198,7 @@ public async Task TransactionDomainService_ProcessReconciliationTransaction_Vali
.ReturnsAsync(new ReconciliationAggregate());
this.AggregateService.Save(Arg<ReconciliationAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success());
this.TransactionValidationService.ValidateReconciliationTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateReconciliationTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(responseCode, responseCode.ToString())));

TransactionCommands.ProcessReconciliationCommand command =
Expand Down Expand Up @@ -239,12 +229,10 @@ public async Task TransactionDomainService_ProcessSaleTransaction_DeclinedByOper

this.AggregateService.GetLatest<FloatAggregate>(Arg<Guid>.Any(), Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(TestData.GetEmptyFloatAggregate()));

this.TransactionValidationService.ValidateSaleTransaction(Arg<Guid>.Any(),
this.TransactionValidationService.ValidateSaleTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
Arg<Guid>.Any(),
Arg<Decimal?>.Any(),
Arg<TransactionSource>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.Success, "SUCCESS")));
Expand Down Expand Up @@ -297,11 +285,9 @@ public async Task TransactionDomainService_ProcessSaleTransaction_OperatorProxyT

this.AggregateService.GetLatest<FloatAggregate>(Arg<Guid>.Any(), Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(TestData.GetEmptyFloatAggregate()));

this.TransactionValidationService.ValidateSaleTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
this.TransactionValidationService.ValidateSaleTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
Arg<Guid>.Any(),
Arg<Decimal?>.Any(),
Arg<TransactionSource>.Any(),
Expand Down Expand Up @@ -344,11 +330,9 @@ public async Task TransactionDomainService_ProcessSaleTransaction_TransactionIsP

this.AggregateService.GetLatest<FloatAggregate>(Arg<Guid>.Any(), Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(floatAggregate));

this.TransactionValidationService.ValidateSaleTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
this.TransactionValidationService.ValidateSaleTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
Arg<Guid>.Any(),
Arg<Decimal?>.Any(),
Arg<TransactionSource>.Any(),
Expand Down Expand Up @@ -408,12 +392,10 @@ public async Task TransactionDomainService_ProcessSaleTransaction_NoFloatFound_T

this.AggregateService.GetLatest<FloatAggregate>(Arg<Guid>.Any(), Arg<CancellationToken>.Any()).ReturnsAsync(Result.NotFound());

this.TransactionValidationService.ValidateSaleTransaction(Arg<Guid>.Any(),
this.TransactionValidationService.ValidateSaleTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
Arg<Guid>.Any(),
Arg<Decimal?>.Any(),
Arg<TransactionSource>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.Success, "SUCCESS")));
Expand Down Expand Up @@ -467,11 +449,9 @@ public async Task TransactionDomainService_ProcessSaleTransaction_ValidationFail
this.AggregateService.Save(Arg<TransactionAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success());

this.TransactionValidationService.ValidateSaleTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
this.TransactionValidationService.ValidateSaleTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
Arg<Guid>.Any(),
Arg<Decimal?>.Any(),
Arg<TransactionSource>.Any(),
Expand Down Expand Up @@ -776,9 +756,7 @@ public async Task TransactionDomainService_ProcessLogonTransaction_SaveFailed_Re
.ReturnsAsync(Result.Success(TestData.GetEmptyTransactionAggregate()));
this.AggregateService.Save(Arg<TransactionAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Failure());
this.TransactionValidationService.ValidateLogonTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateLogonTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.Success, "SUCCESS")));

TransactionCommands.ProcessLogonTransactionCommand command = new(TestData.TransactionId,
Expand Down Expand Up @@ -815,9 +793,7 @@ public async Task TransactionDomainService_ProcessReconciliationTransaction_Save
.ReturnsAsync(new ReconciliationAggregate());
this.AggregateService.Save(Arg<ReconciliationAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Failure());
this.TransactionValidationService.ValidateReconciliationTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
this.TransactionValidationService.ValidateReconciliationTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<CancellationToken>.Any()).ReturnsAsync(Result.Success(new TransactionValidationResult(TransactionResponseCode.Success, "SUCCESS")));

TransactionCommands.ProcessReconciliationCommand command =
Expand Down Expand Up @@ -881,11 +857,9 @@ public async Task TransactionDomainService_ProcessSaleTransaction_SaveFailed_Res
this.AggregateService.Save(Arg<TransactionAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Failure());
this.AggregateService.GetLatest<FloatAggregate>(Arg<Guid>.Any(), Arg<CancellationToken>.Any()).ReturnsAsync(Result.NotFound());
this.TransactionValidationService.ValidateSaleTransaction(Arg<Guid>.Any(),
Arg<Guid>.Any(),
this.TransactionValidationService.ValidateSaleTransaction(Arg<TransactionValidationIdentifiers>.Any(),
Arg<Guid>.Any(),
Arg<Guid>.Any(),
Arg<String>.Any(),
Arg<Guid>.Any(),
Arg<Decimal?>.Any(),
Arg<TransactionSource>.Any(),
Expand Down
Loading
Loading