Skip to content

Fix contract transaction fee table parsing #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Oct 13, 2026
Merged

Fix contract transaction fee table parsing #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff4eb9
Fix contract transaction fee table parsing
StuartFerguson Oct 13, 2026
f9afe80
Merge branch 'main' into task/#1966_integration_test_hardening
StuartFerguson Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions TransactionProcessor.IntegrationTesting.Helpers/SpecflowExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,7 @@ public static List<CreateEstateRequest> ToCreateEstateRequests(this DataTableRow
FeeType feeType = ReqnrollTableHelper.GetEnumValue<FeeType>(tableRow, "FeeType");
String feeDescription = ReqnrollTableHelper.GetStringRowValue(tableRow, "FeeDescription");
Decimal feeValue = ReqnrollTableHelper.GetDecimalValue(tableRow, "Value");
transactionFees.Add((calculationType, feeDescription, feeValue, feeType));
}

return transactionFees;
Expand Down
18 changes: 18 additions & 0 deletions TransactionProcessor.IntegrationTests/Common/SpecflowExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,24 @@ public void ToSettlementFeeDetails_ReturnsEveryFeeRow()
result[1].CalculatedValue.ShouldBe(0.25m);
}

[Test]
public void ToContractTransactionFeeDetails_ReturnsEveryFeeRow()
{
Reqnroll.Table table = new(new[] { "CalculationType", "FeeDescription", "Value", "FeeType" });
table.AddRow(new[] { "Fixed", "Merchant Commission", "1.00", "Merchant" });
table.AddRow(new[] { "Percentage", "Merchant Commission", "0.015", "Merchant" });

List<(CalculationType, String, Decimal?, FeeType)> result = table.Rows.ToContractTransactionFeeDetails();

result.Count.ShouldBe(2);
result[0].Item1.ShouldBe(CalculationType.Fixed);
result[0].Item2.ShouldBe("Merchant Commission");
result[0].Item3.ShouldBe(1.00m);
result[0].Item4.ShouldBe(FeeType.Merchant);
result[1].Item1.ShouldBe(CalculationType.Percentage);
result[1].Item3.ShouldBe(0.015m);
}

[Test]
public void ToSettlementDetails_RejectsMultipleRows()
{
Expand Down
Loading