[StuartFerguson]

Summary

Hardens TransactionProcessor.IntegrationTests and TransactionProcessor.IntegrationTesting.Helpers so invalid setup, failed commands, incomplete read models, and malformed expectations cannot silently allow scenarios to continue.

Closes #1966.

Changes

• Fixed settlement fee parsing so all expected fee assertions execute.
• Replaced unsafe synchronous async assertions with awaited result checks.
• Added command-result validation for contract, estate-operator, device, device-swap, merchant, address, contact, and related setup operations.
• Removed synthetic fallback IDs for unknown contracts/products and added actionable lookup failures.
• Corrected address/contact nested-row processing and identifier-based read-model selection.
• Strengthened settlement, contract, operator, transaction-fee, token, and read-model completeness checks.
• Improved retry behavior and prevented retry callbacks from mutating shared state repeatedly.
• Added explicit null/status checks and fail-fast validation for empty or ambiguous expectation tables.
• Made duplicate merchants and unresolved lookups fail explicitly.
• Added regression coverage for retry behavior and settlement-fee parsing.

Verification

• SpecflowExtensionsTests: 10 passed, 0 failed.
• TransactionProcessor.IntegrationTesting.Helpers build: 0 errors.
• Staged whitespace validation passed.
• Existing package vulnerability warnings remain.
• The full Docker-backed integration suite was not completed in this environment and should be validated by CI.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-12T17:27:40.699141Z	230acd5	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 230acd5c75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}