Skip to content

Return detailed failures when domain event handlers fail - #1941

Merged
StuartFerguson merged 2 commits into
mainfrom
task/#1938_event_failure_responses
Sep 16, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
task/#1938_event_failure_responses

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Capture failures returned by domain event handlers and exceptions thrown during execution.
  • Execute all handlers concurrently and aggregate every failure.
  • Return structured ProblemDetails with event metadata and sanitized handler errors.
  • Add controller tests covering successful, unconfigured, failed, and throwing handlers.
  • Generate an imposter for IDomainEventHandlerResolver.

Testing

  • Added unit tests for domain event controller success and failure scenarios.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 9 complexity

Metric Results
Complexity 9

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95f6fc1cea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson
StuartFerguson merged commit f0c9270 into main Sep 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return detailed failure information from domain event handler responses

1 participant