Skip to content

Improve Agency Banking consistency and test performance - #1896

Merged
StuartFerguson merged 2 commits into
mainfrom
task/#1854_add_constant_agency_banking
Aug 28, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
task/#1854_add_constant_agency_banking

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Centralize Agency Banking JSON request content creation and request-body logging
  • Apply C# modernisation across Agency Banking request construction
  • Improve database and integration test performance and coverage
  • Update float handling, transaction flows, client contracts, migration, and related tests

Testing

  • Updated and expanded unit tests across business logic, aggregates, database events, handlers, and web endpoints

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7083ad698b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -14 complexity

Metric Results
Complexity -14

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit ce023d2 into main Aug 28, 2026
6 checks passed
@github-actions
github-actions Bot deleted the task/#1854_add_constant_agency_banking branch October 28, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Codacy] Define a constant instead of using this literal 'application/json' 4 times.

1 participant