Skip to content

Fix Codacy warnings in mobile transaction and reports code - #690

Merged
StuartFerguson merged 2 commits into
mainfrom
bug/some_codacy_fixes
Aug 27, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
bug/some_codacy_fixes

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary:

  • Centralize the shared sale transaction route constant in TransactionService
  • Convert RecentActivityReceiptReportModel success labels to a shared constant
  • Rename the shadowing selectedItem local in RecentActivityReceiptDetailPageViewModel

Verification:

  • dotnet test TransactionProcessor.Mobile.BusinessLogic.Tests --filter "FullyQualifiedName~TransactionServiceTests" -v minimal
  • dotnet test TransactionProcessor.Mobile.BusinessLogic.Tests --filter "FullyQualifiedName~RecentActivityReceiptReportModel_DefinesSharedSuccessStatusConstant" -v minimal
  • dotnet test TransactionProcessor.Mobile.BusinessLogic.Tests --filter "FullyQualifiedName~RecentActivityReceiptDetailPageViewModelTests" -v minimal

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 1a5351b into main Aug 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant