Skip to content

Add HTTP pipeline failure coverage for transaction services #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Aug 21, 2026
Merged

Add HTTP pipeline failure coverage for transaction services #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 152 additions & 0 deletions TransactionProcessor.Mobile.BusinessLogic.Tests/ServicesTests/TransactionServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,91 @@ Object Deserialise(String arg, Type type)
return StringSerialiser.DeserializeObject<Object>(arg, type, new SerialiserOptions(SerialiserPropertyFormat.SnakeCase));
}

void ArrangeThrowingSaleTransactionHandler()
{
this.MockHttpMessageHandler.When($"http://localhost/api/saletransactions")
.Respond(_ => throw new HttpRequestException("HTTP pipeline failure"));
}

PerformMobileTopupRequestModel CreateMobileTopupRequestModel()
{
return new PerformMobileTopupRequestModel{
ApplicationVersion = TestData.ApplicationVersion,
DeviceIdentifier = TestData.DeviceIdentifier,
TransactionDateTime = TestData.TransactionDateTime,
TransactionNumber = TestData.TransactionNumber,
ContractId = TestData.Operator1ProductDetails.ContractId,
CustomerAccountNumber = TestData.CustomerAccountNumber,
CustomerEmailAddress = TestData.CustomerEmailAddress,
OperatorId = TestData.OperatorId1,
ProductId = TestData.Operator1ProductDetails.ProductId,
TopupAmount = TestData.PaymentAmount
};
}

PerformVoucherIssueRequestModel CreateVoucherIssueRequestModel()
{
return new PerformVoucherIssueRequestModel{
ApplicationVersion = TestData.ApplicationVersion,
DeviceIdentifier = TestData.DeviceIdentifier,
TransactionDateTime = TestData.TransactionDateTime,
TransactionNumber = TestData.TransactionNumber,
ContractId = TestData.Operator1ProductDetails.ContractId,
CustomerEmailAddress = TestData.CustomerEmailAddress,
OperatorId = TestData.OperatorId1,
ProductId = TestData.Operator1ProductDetails.ProductId,
RecipientEmailAddress = TestData.RecipientEmailAddress,
RecipientMobileNumber = TestData.RecipientMobileNumber,
VoucherAmount = TestData.PaymentAmount
};
}

PerformBillPaymentGetAccountModel CreateBillPaymentGetAccountRequestModel()
{
return new PerformBillPaymentGetAccountModel{
ApplicationVersion = TestData.ApplicationVersion,
DeviceIdentifier = TestData.DeviceIdentifier,
TransactionDateTime = TestData.TransactionDateTime,
TransactionNumber = TestData.TransactionNumber,
ContractId = TestData.Operator1ProductDetails.ContractId,
OperatorId = TestData.OperatorId1,
ProductId = TestData.Operator1ProductDetails.ProductId,
CustomerAccountNumber = TestData.CustomerAccountNumber,
};
}

PerformBillPaymentGetMeterModel CreateBillPaymentGetMeterRequestModel()
{
return new PerformBillPaymentGetMeterModel{
ApplicationVersion = TestData.ApplicationVersion,
DeviceIdentifier = TestData.DeviceIdentifier,
TransactionDateTime = TestData.TransactionDateTime,
TransactionNumber = TestData.TransactionNumber,
ContractId = TestData.Operator1ProductDetails.ContractId,
OperatorId = TestData.OperatorId1,
ProductId = TestData.Operator1ProductDetails.ProductId,
MeterNumber = TestData.MeterNumber
};
}

PerformBillPaymentMakePaymentModel CreateBillPaymentMakePaymentRequestModel(Boolean isPostPayment)
{
return new PerformBillPaymentMakePaymentModel{
ApplicationVersion = TestData.ApplicationVersion,
DeviceIdentifier = TestData.DeviceIdentifier,
TransactionDateTime = TestData.TransactionDateTime,
TransactionNumber = TestData.TransactionNumber,
ContractId = TestData.Operator1ProductDetails.ContractId,
OperatorId = TestData.OperatorId1,
ProductId = TestData.Operator1ProductDetails.ProductId,
CustomerAccountName = TestData.CustomerAccountName,
PaymentAmount = TestData.PaymentAmount,
CustomerAccountNumber = TestData.CustomerAccountNumber,
CustomerMobileNumber = TestData.CustomerMobileNumber,
PostPayment = isPostPayment
};
}

public TransactionServiceTests(){
this.MockHttpMessageHandler = new MockHttpMessageHandler();
this.BaseAddressResolver = (s) => $"http://localhost";
Expand Down Expand Up @@ -172,6 +257,19 @@ public async Task TransactionService_PerformMobileTopup_MobileTopupPerformed(){
performMobileTopupResult.Data.IsSuccessful.ShouldBeTrue();
}

[Fact]
public async Task TransactionService_PerformMobileTopup_ReturnsFailureWhenHttpPipelineThrows()
{
PerformMobileTopupRequestModel requestModel = this.CreateMobileTopupRequestModel();

this.ArrangeThrowingSaleTransactionHandler();

Result<PerformMobileTopupResponseModel> result = await this.TransactionService.PerformMobileTopup(requestModel, CancellationToken.None);

result.IsFailed.ShouldBeTrue();
result.Message.ShouldBe("Error performing Mobile top-up transaction");
}

[Fact]
public async Task TransactionService_PerformVoucherIssue_MobileTopupFailed(){

Expand Down Expand Up @@ -260,6 +358,19 @@ public async Task TransactionService_PerformVoucherIssue_VoucherIssueFailed(){
performVoucherIssueResult.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task TransactionService_PerformVoucherIssue_ReturnsFailureWhenHttpPipelineThrows()
{
PerformVoucherIssueRequestModel requestModel = this.CreateVoucherIssueRequestModel();

this.ArrangeThrowingSaleTransactionHandler();

Result<PerformVoucherIssueResponseModel> result = await this.TransactionService.PerformVoucherIssue(requestModel, CancellationToken.None);

result.IsFailed.ShouldBeTrue();
result.Message.ShouldBe("Error performing Voucher transaction");
}

[Fact]
public async Task TransactionService_PerformBillPaymentGetAccount_GetAccountPerformed() {
PerformBillPaymentGetAccountModel requestModel = new PerformBillPaymentGetAccountModel{
Expand Down Expand Up @@ -324,6 +435,19 @@ public async Task TransactionService_PerformBillPaymentGetAccount_GetAccountFail
performBillPaymentGetAccountResult.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task TransactionService_PerformBillPaymentGetAccount_ReturnsFailureWhenHttpPipelineThrows()
{
PerformBillPaymentGetAccountModel requestModel = this.CreateBillPaymentGetAccountRequestModel();

this.ArrangeThrowingSaleTransactionHandler();

Result<PerformBillPaymentGetAccountResponseModel> result = await this.TransactionService.PerformBillPaymentGetAccount(requestModel, CancellationToken.None);

result.IsFailed.ShouldBeTrue();
result.Message.ShouldBe("Error performing bill payment - get account transaction");
}


[Fact]
public async Task TransactionService_PerformBillPaymentGetMeter_GetMeterPerformed(){
Expand Down Expand Up @@ -416,6 +540,19 @@ public async Task TransactionService_PerformBillPaymentGetMeter_GetMeterFailed()
performBillPaymentGetMeterResult.IsFailed.ShouldBeTrue();
}

[Fact]
public async Task TransactionService_PerformBillPaymentGetMeter_ReturnsFailureWhenHttpPipelineThrows()
{
PerformBillPaymentGetMeterModel requestModel = this.CreateBillPaymentGetMeterRequestModel();

this.ArrangeThrowingSaleTransactionHandler();

Result<PerformBillPaymentGetMeterResponseModel> result = await this.TransactionService.PerformBillPaymentGetMeter(requestModel, CancellationToken.None);

result.IsFailed.ShouldBeTrue();
result.Message.ShouldBe("Error performing bill payment - get meter transaction");
}

[Theory]
[InlineData(true)]
[InlineData(false)]
Expand Down Expand Up @@ -453,6 +590,21 @@ public async Task TransactionService_PerformBillPaymentMakePayment_MakePaymentPe
performBillPaymentGetMeterResult.Data.IsSuccessful.ShouldBeTrue();
}

[Theory]
[InlineData(true)]
[InlineData(false)]
public async Task TransactionService_PerformBillPaymentMakePayment_ReturnsFailureWhenHttpPipelineThrows(Boolean isPostPayment)
{
PerformBillPaymentMakePaymentModel requestModel = this.CreateBillPaymentMakePaymentRequestModel(isPostPayment);

this.ArrangeThrowingSaleTransactionHandler();

Result<PerformBillPaymentMakePaymentResponseModel> result = await this.TransactionService.PerformBillPaymentMakePayment(requestModel, CancellationToken.None);

result.IsFailed.ShouldBeTrue();
result.Message.ShouldBe("Error performing bill payment - make payment transaction");
}

[Theory]
[InlineData(true)]
[InlineData(false)]
Expand Down
Loading