Skip to content

Support optional health URLs and capture SQL Server versions - #768

Merged
StuartFerguson merged 3 commits into
mainfrom
codex/sql-server-version-optional-health-url
Sep 21, 2026
Merged

StuartFerguson merged 3 commits into
mainfrom
codex/sql-server-version-optional-health-url

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Allow database monitors to register without an HTTP health URL.
  • Make HealthUrl nullable across contracts, domain models, persistence, and UI handling.
  • Add a migration to make stored health URLs optional.
  • Resolve and store a human-readable SQL Server version during registration and initialization.
  • Add validation, formatting, fallback, and initialization coverage for SQL Server versions and database registrations.

Testing

  • Added unit and initialization tests covering optional database health URLs, SQL Server version formatting, query failures, and registration capture.
  • Not run (not requested).

@codacy-production

codacy-production Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 22 complexity

Metric Results
Complexity 22

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e13adcd1ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson
StuartFerguson merged commit e1b3940 into main Sep 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collect and display human-readable SQL Server version on registration

2 participants