Skip to content

Fix Codacy warnings in merchant worker and HealthChecksUI #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Aug 26, 2026
Merged

Fix Codacy warnings in merchant worker and HealthChecksUI #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions TransactionProcessing.MerchantFileProcessor/Reporting/OperationsDashboardService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ private static void AppendSummaryPanel(StringBuilder html, string title, IEnumer
}

html.AppendLine(" </dl>");
html.AppendLine(" </section>");
html.AppendLine(SectionEnd);
}

private static void AppendMerchantConfigPanel(StringBuilder html)
Expand All @@ -629,7 +629,7 @@ private static void AppendMerchantConfigPanel(StringBuilder html)
html.AppendLine(" <li>SQLite is used for the local audit trail and status tables.</li>");
html.AppendLine(" <li>Merchant schedules are interpreted in UTC and backed by the worker loop.</li>");
html.AppendLine(" </ul>");
html.AppendLine(" </section>");
html.AppendLine(SectionEnd);
}

private static void AppendFileProfilesSection(StringBuilder html, IReadOnlyList<FileProfileRow> fileProfiles)
Expand Down Expand Up @@ -658,7 +658,7 @@ private static void AppendFileProfilesSection(StringBuilder html, IReadOnlyList<

html.AppendLine(TableBodyEnd);
html.AppendLine(TableEnd);
html.AppendLine(" </section>");
html.AppendLine(SectionEnd);
}

private static void AppendContractsSection(StringBuilder html, IReadOnlyList<ContractMappingRow> contracts)
Expand All @@ -684,7 +684,7 @@ private static void AppendContractsSection(StringBuilder html, IReadOnlyList<Con

html.AppendLine(TableBodyEnd);
html.AppendLine(TableEnd);
html.AppendLine(" </section>");
html.AppendLine(SectionEnd);
}

private static void AppendDocumentStart(StringBuilder html, string title, string subtitle)
Expand Down
3 changes: 2 additions & 1 deletion TransactionProcessor.HealthChecksUI/TransactionProcessor.HealthChecksUI/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ public void ConfigureServices(IServiceCollection services){
}).AddInMemoryStorage();
}

private HttpClientHandler ApiEndpointHttpHandler(IServiceProvider _)
private HttpClientHandler ApiEndpointHttpHandler(IServiceProvider serviceProvider)
{
System.ArgumentNullException.ThrowIfNull(serviceProvider);
return new HttpClientHandler();
}

Expand Down
Loading