Skip to content

Address remaining Codacy findings - #670

Merged
StuartFerguson merged 3 commits into
mainfrom
task/warning_package_2
Aug 26, 2026
Merged

StuartFerguson merged 3 commits into
mainfrom
task/warning_package_2

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

This PR clears the remaining Codacy-reported issues across MerchantFileProcessor, MerchantPos, SystemSetupTool, HealthChecksUI, and the ReplayParkedQueue script.

Highlights:

  • Encapsulated MerchantMetricSnapshot fields behind methods/properties
  • Extracted repeated route and metadata string literals
  • Reduced parameter count in FileStatusStore::RecordAsync via a request record
  • Removed stale comments and TODO markers
  • Fixed the empty catch in ReplayParkedQueue cleanup
  • Updated HealthChecksUI startup/Program signatures and EventStoreFunctions string reuse

Verification:

  • dotnet build TransactionProcessing.MerchantFileProcessor\TransactionProcessing.MerchantFileProcessor.sln -v minimal
  • dotnet build TransactionProcessing.MerchantPos\TransactionProcessing.MerchantPos.csproj -v minimal
  • dotnet build TransactionProcessor.SystemSetupTool\TransactionProcessor.SystemSetupTool.csproj -v minimal
  • dotnet build TransactionProcessor.HealthChecksUI\TransactionProcessor.HealthChecksUI\TransactionProcessor.HealthChecksUI.csproj -v minimal

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 7714cb2 into main Aug 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant