Skip to content

Reduce MerchantRuntime trading-hours method complexity - #666

Merged
StuartFerguson merged 1 commit into
mainfrom
task/#664_method_complexity
Aug 26, 2026
Merged

StuartFerguson merged 1 commit into
mainfrom
task/#664_method_complexity

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Extract trading-hours resolution into a dedicated helper.
  • Extract opening-time delays and after-closing reconciliation handling into focused methods.
  • Preserve merchant-specific hours, fallback configuration, reconciliation, logging, and cancellation behavior.

Testing

Not run (not requested).

closes #664

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit c09a740 into main Aug 26, 2026
7 checks passed
@github-actions
github-actions Bot deleted the task/#664_method_complexity branch October 26, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Codacy] Method MerchantRuntime::RunMainLoop has a cyclomatic complexity of 14 (limit is 12)

1 participant