Repository navigation
Resolve Codacy warning backlog - #663
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f976b9aca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return true; | ||
| } | ||
| }; | ||
| return new HttpClientHandler(); |
There was a problem hiding this comment.
The checked-in default, staging, and preproduction configurations probe services through HTTPS URLs on private IP addresses, and this custom handler was originally added specifically to fix those HTTPS checks. Replacing it with the default handler makes those probes enforce normal certificate-chain and hostname validation, so installations still using the existing development/private certificates will report every HTTPS service as unhealthy. Install the appropriate CA/certificate or retain a narrowly scoped development handler before removing the callback.
Useful? React with 👍 / 👎.
| return true; | ||
| } | ||
| }; | ||
| HttpClientHandler handler = new(); |
There was a problem hiding this comment.
With the checked-in TransactionProcessor.SystemSetupTool/appsettings.json, the security client connects to https://192.168.1.163:5001; this validation override was introduced alongside the switch of that endpoint from HTTP to HTTPS. The default handler now rejects the existing private/development certificate when its chain or IP identity is not trusted, causing token acquisition—and therefore the default estate setup flow—to fail before any setup calls run. Trust the deployment CA explicitly or make relaxed validation an opt-in development setting rather than removing the only certificate handling.
Useful? React with 👍 / 👎.
| return true; | ||
| } | ||
| }; | ||
| HttpClientHandler handler = new HttpClientHandler(); |
There was a problem hiding this comment.
The data generator immediately uses this client to request a token from the hard-coded https://192.168.1.163:5001 security-service URL. In environments using the private/development certificate for which the previous callback was required, the default handler fails TLS validation and the generator cannot start generating data. Configure a trusted certificate/CA or gate the permissive handler to the development generator environment instead of unconditionally removing it.
Useful? React with 👍 / 👎.
This branch resolves the Codacy warning backlog and cleans up the affected projects. Closes #620, #621, #624, #627, #631, #634, #635, #637, #646, #647, #649, #650, #651, #652, #653, #656, #657, #658.