Skip to content

Generalise DbContextResolver and query timing - #1335

Merged
StuartFerguson merged 2 commits into
mainfrom
feature/#1322_generalise_dbcontext_resolver
Oct 19, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
feature/#1322_generalise_dbcontext_resolver

Conversation

@StuartFerguson

@StuartFerguson StuartFerguson commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Generalise DbContextResolver<TContext> with safe catalog suffixing, configurable retry settings, and interceptor support while preserving unsuffixed resolution.
  • Add an independently configurable query timing interceptor for sync and async reader, scalar, and non-query commands.
  • Document resolver and interceptor configuration.

Closes #1322.

Verification

  • Resolver tests passed (10 tests), including the regression case for non-SQL connection strings on unsuffixed resolution.
  • git diff --check passed.
  • dotnet test Shared.sln --no-restore could not complete because Shared.EventStoreContext.Tests.EventStoreContext_InsertEvents_RetriesAfterDockerOutage could not start the docker executable in this environment.

@StuartFerguson
StuartFerguson marked this pull request as ready for review October 19, 2026 15:15
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T15:16:39.656279Z 8d912d6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d912d6552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 29 complexity · 0 duplication

Metric Results
Complexity 29
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 9ad02a1 into main Oct 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalise DbContextResolver to support suffixed databases and interceptors

1 participant