Skip to content

Improve integration test container startup reliability - #1327

Merged
StuartFerguson merged 7 commits into
mainfrom
task/changes_for_docker_startup_stability
Oct 12, 2026
Merged

StuartFerguson merged 7 commits into
mainfrom
task/changes_for_docker_startup_stability

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • require cancellation throughout container startup and retry flows
  • make startup and projection failures propagate promptly
  • reuse the EventStore health-check HttpClient across retries
  • capture container logs when startup or health checks fail
  • retain the cleanup and resource-tracking fixes from the previous merged PR
  • remove obsolete Docker platform detection and simplify host-folder mounts

Verification

  • DockerHelperStartupPlanTests: 6 passed
  • Shared.IntegrationTesting.UnitTests: 29 passed
  • Shared.EventStoreContext.Tests: build succeeded
  • git diff --check: passed

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T10:42:25.162701Z 96ef32c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96ef32c705

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson
StuartFerguson merged commit 42d1159 into main Oct 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant