Skip to content

Reduce login OnPostAsync complexity (#1746) - #1768

Merged
StuartFerguson merged 1 commit into
mainfrom
bug/#1746_login_index_onpost_complexity
Oct 22, 2026
Merged

StuartFerguson merged 1 commit into
mainfrom
bug/#1746_login_index_onpost_complexity

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Handle login rejection outcomes explicitly and reduce branching in OnPostAsync().
  • Add page model tests for cancel, forgot password, failed login, completed login, MFA, MFA enrollment, and unsupported outcomes.

Verification

  • Tests could not run in this environment. Restore/build exits while walking project references (_GenerateRestoreProjectPathWalk) with no reported errors or warnings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T19:11:15.559523Z d87c9bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics -5 complexity · 0 duplication

Metric Results
Complexity -5
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 122b351 into main Oct 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Codacy] Method IndexModel::OnPostAsync has a cyclomatic complexity of 14 (limit is 12)

1 participant