Skip to content

use provided passsword in integration tests - #1757

Merged
StuartFerguson merged 1 commit into
mainfrom
task/#1756_use_password_for_user_in_testmode
Oct 9, 2026
Merged

StuartFerguson merged 1 commit into
mainfrom
task/#1756_use_password_for_user_in_testmode

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T17:17:50.065780Z 600cd1a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

newIdentityUser.PasswordHash = this.PasswordHasher.HashPassword(newIdentityUser, passwordValueResult.Data);

P2 Badge Validate supplied passwords before hashing

When the integration-only flag is enabled and an email user's supplied password violates the configured Identity policy (for example, it is shorter than RequiredLength), HashPassword still accepts it and the later CreateAsync(user) call does not run password validators because no password is passed to UserManager. The integration environment can therefore create credentials that the normal Identity creation or reset flow would reject, making password-related tests inaccurate; use a password-aware UserManager operation or explicitly run the configured validators before storing the hash.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson
StuartFerguson merged commit 128d84d into main Oct 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow integration tests to use supplied passwords for email-backed users

1 participant