Skip to content

Add missing security regression tests - #1753

Merged
StuartFerguson merged 2 commits into
mainfrom
task/#1730_missing_tests_added
Oct 7, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
task/#1730_missing_tests_added

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Add client-registration regression coverage for legacy grant allowlisting.
  • Assert legacy password clients receive only the permissions they requested.
  • Verify Data Protection keys can be reused across provider instances.

Related to #1730.

Verification

  • Unit test executable: 160/160 applicable tests passed.
  • Full unit run: 162 total, with 2 existing certificate-loader failures caused by sandbox PFX private-key restrictions.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T18:01:16.486991Z 25ab34c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25ab34c77d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson StuartFerguson linked an issue Oct 7, 2026 that may be closed by this pull request
@StuartFerguson
StuartFerguson merged commit 77711e4 into main Oct 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand security-focused integration coverage

1 participant