Skip to content

Fix TLS handshake regression when loading Kestrel certificates - #1749

Merged
StuartFerguson merged 1 commit into
mainfrom
bug/#1748_tls_regression
Oct 7, 2026
Merged

StuartFerguson merged 1 commit into
mainfrom
bug/#1748_tls_regression

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • revert the ephemeral-key loading change introduced by the certificate-loader update
  • restore successful Kestrel TLS handshakes for the configured PFX certificate

Verification

  • dotnet build SecurityService\SecurityService.csproj --no-restore
  • certificate-loader tests: 4 passed via the Microsoft Testing Platform test assembly
  • OpenSSL TLS 1.3 handshake completed against the locally running service

Closes #1748

Note: certificate expiry and hostname/IP SAN validation are separate certificate-management concerns and are intentionally not changed by this fix.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T14:17:24.415786Z f177392 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit f6739d6 into main Oct 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTPS health endpoint drops TLS handshake after certificate-loader change

1 participant