Skip to content

Fix line terminator parsing in duplicate profile test - #872

Merged
StuartFerguson merged 1 commit into
mainfrom
bug/#855_fix_line_terminator_parser
Oct 27, 2026
Merged

StuartFerguson merged 1 commit into
mainfrom
bug/#855_fix_line_terminator_parser

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Treat only null or empty line terminator strings as missing in the integration-test parser.
  • Preserve LF, CRLF, and CR values so duplicate-profile requests reach duplicate validation.

Fixes #855.

Verification

  • dotnet build FileProcessor.IntegrationTests/FileProcessor.IntegrationTests.csproj --configuration Release --no-restore
  • RejectDuplicateFileProfileNameAndRequestType integration scenario passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T13:23:02.647533Z 4db486f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 39e3400 into main Oct 27, 2026
6 checks passed
@StuartFerguson StuartFerguson linked an issue Oct 27, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate Nightly Build Failure Investigate recurring file profile duplicate validation test failure

1 participant