Skip to content

Return accepted for idempotent file uploads - #857

Merged
StuartFerguson merged 3 commits into
mainfrom
bug/#802_upload_acceptance_idempotency
Oct 17, 2026
Merged

StuartFerguson merged 3 commits into
mainfrom
bug/#802_upload_acceptance_idempotency

Conversation

@StuartFerguson

@StuartFerguson StuartFerguson commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Return HTTP 202 Accepted for successful upload submissions.
  • Make repeated uploads idempotent by file ID and validate upload references before processing.
  • Configure upload size and extension limits, and reject invalid multipart uploads.
  • Update duplicate upload tests and scenarios to expect idempotent acceptance.

Closes #802

Validation

  • dotnet test FileProcessor.FileImportLogAggregate.Tests/FileProcessor.FileImportLogAggregate.Tests.csproj --no-restore passed (7 tests).
  • dotnet test FileProcessor.BusinessLogic.Tests/FileProcessor.BusinessLogic.Tests.csproj --no-restore passed (141 tests).
  • dotnet build FileProcessor.IntegrationTests/FileProcessor.IntegrationTests.csproj --no-restore passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T09:23:36.649731Z 6d6ff17 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 45 complexity · 1 duplication

Metric Results
Complexity 45
Duplication 1

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d6ff172f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread FileProcessor/Handlers/FileHandlers.cs Resolved
@StuartFerguson
StuartFerguson merged commit 7942d2f into main Oct 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden upload API and add asynchronous processing status

1 participant