Skip to content

Add file-level validation and duplicate row handling - #837

Merged
StuartFerguson merged 4 commits into
mainfrom
task/#803_correct-import-log-diagnostics
Oct 16, 2026
Merged

StuartFerguson merged 4 commits into
mainfrom
task/#803_correct-import-log-diagnostics

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Add file-level schema/content validation for Safaricom and Voucher imports.
  • Reject invalid files before any transaction events are dispatched.
  • Record duplicate rows with DuplicateFileLineAddedEvent without downstream processing.
  • Add structured validation diagnostics and automated coverage.

Testing

  • dotnet build FileProcessor.sln --no-restore — passed.
  • BusinessLogic tests — 120 passed.
  • FileAggregate tests — 27 passed.
  • Full integration tests require Docker, which was unavailable in the development environment.

Closes #797

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T14:54:24.456268Z 18d857c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 29 complexity · 0 duplication

Metric Results
Complexity 29
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18d857c4e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson
StuartFerguson merged commit e4286cc into main Oct 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add file-level schema and content validation

1 participant