Skip to content

Reject oversized files with an audit event - #831

Merged
StuartFerguson merged 7 commits into
mainfrom
task/#796_upload-temp-file-processing
Oct 16, 2026
Merged

StuartFerguson merged 7 commits into
mainfrom
task/#796_upload-temp-file-processing

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • enforce a configurable 1,000-detail-record maximum (default)
  • persist oversized-file rejection as a FileRejectedEvent without adding line events
  • expose rejection metadata through file details and move rejected files to the failed directory
  • add aggregate, service, and opt-in Reqnroll coverage for 1,000 and 1,001 detail rows

Verification

  • dotnet test FileProcessor.FileAggregate.Tests/FileProcessor.FileAggregate.Tests.csproj --no-restore
  • dotnet test FileProcessor.BusinessLogic.Tests/FileProcessor.BusinessLogic.Tests.csproj --no-restore
  • dotnet test FileProcessor.Tests/FileProcessor.Tests.csproj --no-restore
  • dotnet build FileProcessor/FileProcessor.csproj --no-restore
  • dotnet build FileProcessor.IntegrationTests/FileProcessor.IntegrationTests.csproj --no-restore

The Docker-backed Reqnroll scenarios are opt-in and were build-verified but not run end-to-end in this environment.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T11:04:21.123253Z 6efcd20 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

codacy-production Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 10 complexity · 2 duplication

Metric Results
Complexity 10
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6efcd201e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson StuartFerguson linked an issue Oct 16, 2026 that may be closed by this pull request
@StuartFerguson StuartFerguson linked an issue Oct 16, 2026 that may be closed by this pull request
@StuartFerguson
StuartFerguson merged commit 42fbd75 into main Oct 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Shared Nugets Define and enforce a practical maximum file size

1 participant