Skip to content

Fix upload temporary file handling - #828

Merged
StuartFerguson merged 2 commits into
mainfrom
task/#796_upload-temp-file-processing
Oct 15, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
task/#796_upload-temp-file-processing

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Store HTTP uploads under a generated temporary filename.
  • Preserve the original client filename in the import log metadata.
  • Remove temporary files when EventStore acceptance fails.
  • Preserve post-acceptance moves to ProcessedDirectory and FailedDirectory.
  • Add regression coverage for retries, filename safety, cleanup, and processing failures.

Verification

  • BusinessLogic test project: 104 tests passed.
  • Solution build: passed with 0 errors.
  • git diff --check: passed.
  • The full integration test run was not included because the existing integration runner hung in this environment.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T12:43:22.578656Z 1e298f2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 9 complexity · 0 duplication

Metric Results
Complexity 9
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e298f2684

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread FileProcessor/Handlers/FileHandlers.cs Resolved
@StuartFerguson StuartFerguson linked an issue Oct 15, 2026 that may be closed by this pull request
@StuartFerguson
StuartFerguson merged commit 1594802 into main Oct 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace listening-directory handoff with durable file storage

1 participant