Skip to content

Refactor GetDetailsForTransaction complexity - #824

Merged
StuartFerguson merged 6 commits into
mainfrom
task/#792_getdetailsfortransaction_refactor
Oct 13, 2026
Merged

StuartFerguson merged 6 commits into
mainfrom
task/#792_getdetailsfortransaction_refactor

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Reduce GetDetailsForTransaction cyclomatic complexity below the Codacy threshold.
  • Extract merchant, contract, product, and device validation/lookup helpers.
  • Preserve existing behavior and error messages.

Verification

  • dotnet test FileProcessor.BusinessLogic.Tests/FileProcessor.BusinessLogic.Tests.csproj --no-restore (100 passed)
  • Other unit and aggregate test projects passed in the solution run.
  • Integration tests hung without output and were stopped after a bounded wait.

Fixes #792

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T12:38:45.419509Z efab930 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 9 complexity · 0 duplication

Metric Results
Complexity 9
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson
StuartFerguson merged commit 3791130 into main Oct 13, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Codacy] Method FileProcessorDomainService::GetDetailsForTransaction has a cyclomatic complexity of 14 (limit is 12)

1 participant