Skip to content

pass event id up in the transaction metadata #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Sep 16, 2026
Merged

pass event id up in the transaction metadata #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions FileProcessor.BusinessLogic.Tests/FileProcessorDomainServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,13 +661,13 @@ public async Task FileRequestHandler_ProcessTransactionLineForFileRequest_LineIn
this.FileAggregateRepository.SaveChanges(Arg<FileAggregate>.Any(), Arg<CancellationToken>.Any())
.ReturnsAsync(Result.Success());
FileCommands.ProcessTransactionForFileLineCommand processTransactionForFileLineRequest1 =
new (TestData.FileId, 1, TestData.FileLine1);
new (TestData.FileId, TestData.FileLineAddedEvent.EventId, 1, TestData.FileLine1);
FileCommands.ProcessTransactionForFileLineCommand processTransactionForFileLineRequest2 =
new (TestData.FileId, 1, TestData.FileLine2);
new (TestData.FileId, TestData.FileLineAddedEvent.EventId, 1, TestData.FileLine2);
FileCommands.ProcessTransactionForFileLineCommand processTransactionForFileLineRequest3 =
new (TestData.FileId, 3, TestData.FileLine3);
new (TestData.FileId, TestData.FileLineAddedEvent.EventId, 3, TestData.FileLine3);
FileCommands.ProcessTransactionForFileLineCommand processTransactionForFileLineRequest4 =
new (TestData.FileId, 4, TestData.FileLine4);
new (TestData.FileId, TestData.FileLineAddedEvent.EventId, 4, TestData.FileLine4);

var result1 = await this.FileProcessorDomainService.ProcessTransactionForFileLine(processTransactionForFileLineRequest1, CancellationToken.None);
var result2 = await this.FileProcessorDomainService.ProcessTransactionForFileLine(processTransactionForFileLineRequest2, CancellationToken.None);
Expand Down
2 changes: 1 addition & 1 deletion FileProcessor.BusinessLogic/EventHandling/FileDomainEventHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public async Task<Result> Handle(IDomainEvent domainEvent,
private async Task<Result> HandleSpecificDomainEvent(FileLineAddedEvent domainEvent,
CancellationToken cancellationToken)
{
FileCommands.ProcessTransactionForFileLineCommand command = new (domainEvent.FileId, domainEvent.LineNumber, domainEvent.FileLine);
FileCommands.ProcessTransactionForFileLineCommand command = new (domainEvent.FileId, domainEvent.EventId, domainEvent.LineNumber, domainEvent.FileLine);
try
{
Result result = await this.Mediator.Send(command, cancellationToken);
Expand Down
2 changes: 1 addition & 1 deletion FileProcessor.BusinessLogic/Requests/FileCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace FileProcessor.BusinessLogic.Requests;

[ExcludeFromCodeCoverage]
public record FileCommands {
public record ProcessTransactionForFileLineCommand(Guid FileId, Int32 LineNumber, String FileLine)
public record ProcessTransactionForFileLineCommand(Guid FileId, Guid EventId, Int32 LineNumber, String FileLine)
: IRequest<Result>;

public record ProcessUploadedFileCommand(Guid EstateId,
Expand Down
3 changes: 2 additions & 1 deletion FileProcessor.BusinessLogic/Services/FileProcessorDomainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,8 @@ private Result<Dictionary<String, String>> BuildTransactionMetadata(FileCommands
// Add the file data to the request metadata
transactionMetadata.Add("FileId", command.FileId.ToString());
transactionMetadata.Add("FileLineNumber", fileLine.LineNumber.ToString());

transactionMetadata.Add("EventId", command.EventId.ToString());

operatorName = fileProfile.OperatorName;
if (transactionMetadata.ContainsKey("OperatorName")) {
// extract the value
Expand Down
2 changes: 1 addition & 1 deletion FileProcessor.Testing/TestData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ public static List<ContractResponse> GetMerchantContractsResponseNoNullValueProd
TestData.FileUploadedDateTime);

public static FileCommands.ProcessTransactionForFileLineCommand ProcessTransactionForFileLineCommand =>
new (TestData.FileId, TestData.LineNumber, TestData.FileLine);
new (TestData.FileId, TestData.FileLineAddedEvent.EventId, TestData.LineNumber, TestData.FileLine);

public static FileQueries.GetFileQuery GetFileQuery => new(FileId, EstateId);

Expand Down
Loading