Repository navigation
Refactor line terminator handling with enum type - #769
Merged
Merged
Conversation
Replaced string-based line terminator properties with a new LineTerminatorType enum in file profile requests. Updated all usages, validation, and tests to use the strongly-typed enum. Added extension methods for conversion and enhanced validation to reject invalid or unknown values. Updated test cases and step definitions to support the new approach.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | -4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
github-actions
Bot
deleted the
bug/#759_reject_invalid_line_terminators
branch
September 13, 2026 02:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced string-based line terminator properties with a new LineTerminatorType enum in file profile requests. Updated all usages, validation, and tests to use the strongly-typed enum. Added extension methods for conversion and enhanced validation to reject invalid or unknown values. Updated test cases and step definitions to support the new approach.