Skip to content

remove some redundant code to clean up code base #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 1 commit into from
Oct 29, 2026
Merged

remove some redundant code to clean up code base #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions EstateReportingAPI.BusinessLogic/Services/TransactionReportingService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,6 @@ public async Task<Result<TodaysSales>> GetTodaysSales(TransactionQueries.TodaysS
return Result.Success(response);
}

private Int32 SafeDivide(Int32 number,
Int32 divisor) {
if (divisor == 0) return number;

return number / divisor;
}

private Decimal SafeDivide(Decimal number,
Int32 divisor) {
if (divisor == 0) return number;
Expand Down Expand Up @@ -1177,10 +1170,7 @@ private static List<MetricItem> BuildMerchantDailyPerformanceMetrics(List<Mercha
.OrderByDescending(x => x.SalesCount)
.ThenBy(x => x.ProductName)
.FirstOrDefault();

if (topProduct == null)
return null;


return new MetricItem {
Title = "Top Product Sales Count",
Value = topProduct.SalesCount,
Expand Down
Loading