Skip to content

added scalar and api defaults #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 5 commits into from
Oct 21, 2026
Merged

added scalar and api defaults #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6380c8c
added scalar and api defaults
StuartFerguson Oct 21, 2026
3d8e97e
Use valid page size in OpenAPI examples
StuartFerguson Oct 21, 2026
d83e6c8
Use application configuration for service registration
StuartFerguson Oct 21, 2026
1facf1d
Skip external authentication setup in integration tests
StuartFerguson Oct 21, 2026
eee0188
Address Codacy feedback on OpenAPI documentation
StuartFerguson Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 12 additions & 17 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,57 +3,52 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="HealthMonitoring.Client" Version="2026.9.4.53" />
<PackageVersion Include="HealthMonitoring.Client" Version="2026.10.1" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.13" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.13" />
<PackageVersion Include="Microsoft.EntityFrameworkCore" Version="10.0.13" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.SqlServer" Version="10.0.13" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Relational" Version="10.0.13" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Tools" Version="10.0.13" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />
<PackageVersion Include="Imposter" Version="1.0.1" />
<PackageVersion Include="SharpCompress" Version="0.50.5" />
<PackageVersion Include="Imposter" Version="1.0.3" />
<PackageVersion Include="SharpCompress" Version="0.50.7" />
<PackageVersion Include="Shouldly" Version="4.3.0" />
<PackageVersion Include="SSH.NET" Version="2026.0.0" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="10.3.0" />
<PackageVersion Include="System.Security.Cryptography.Pkcs" Version="10.0.13" />
<PackageVersion Include="TransactionProcessor.Database" Version="2026.9.3.409" />
<PackageVersion Include="TransactionProcessing.ApiDefaults" Version="2026.10.4" />
<PackageVersion Include="TransactionProcessor.Database" Version="2026.10.1" />
<PackageVersion Include="xunit.v3" Version="4.0.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="4.0.1" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.12.0" />
<PackageVersion Include="ClientProxyBase" Version="2026.10.3" />
<PackageVersion Include="Shared.Results" Version="2026.10.3" />
<PackageVersion Include="ClientProxyBase" Version="2026.10.4" />
<PackageVersion Include="Shared.Results" Version="2026.10.4" />
<PackageVersion Include="MediatR" Version="14.2.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.DynamicLinq" Version="10.7.4" />
<PackageVersion Include="Microsoft.AspNetCore.OpenApi" Version="10.0.13" />
<PackageVersion Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.23.0" />
<PackageVersion Include="Shared.Results.Web" Version="2026.10.3" />
<PackageVersion Include="Shared.Results.Web" Version="2026.10.4" />
<PackageVersion Include="OpenIddict.Validation.AspNetCore" Version="7.7.2" />
<PackageVersion Include="OpenIddict.Validation.SystemNetHttp" Version="7.7.2" />
<PackageVersion Include="Lamar" Version="16.0.0" />
<PackageVersion Include="Lamar.Microsoft.DependencyInjection" Version="16.0.0" />
<PackageVersion Include="NLog.Extensions.Logging" Version="6.2.2" />
<PackageVersion Include="Shared" Version="2026.10.3" />
<PackageVersion Include="Shared" Version="2026.10.4" />
<PackageVersion Include="AspNetCore.HealthChecks.SqlServer" Version="9.0.0" />
<PackageVersion Include="AspNetCore.HealthChecks.UI.Client" Version="9.0.0" />
<PackageVersion Include="AspNetCore.HealthChecks.UI.InMemory.Storage" Version="9.0.0" />
<PackageVersion Include="AspNetCore.HealthChecks.Uris" Version="9.0.0" />
<PackageVersion Include="Microsoft.Extensions.Hosting.WindowsServices" Version="10.0.13" />
<PackageVersion Include="Swashbuckle.AspNetCore.Annotations" Version="10.3.0" />
<PackageVersion Include="Swashbuckle.AspNetCore.Filters" Version="10.0.1" />
<PackageVersion Include="Swashbuckle.AspNetCore.Swagger" Version="10.3.0" />
<PackageVersion Include="Swashbuckle.AspNetCore.SwaggerGen" Version="10.3.0" />
<PackageVersion Include="Swashbuckle.AspNetCore.SwaggerUI" Version="10.3.0" />
<PackageVersion Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="10.0.13" />
<PackageVersion Include="Sentry.AspNetCore" Version="6.12.1" />
<PackageVersion Include="Shared.Logger" Version="2026.10.3" />
<PackageVersion Include="Shared.IntegrationTesting" Version="2026.10.3" />
<PackageVersion Include="Shared.Logger" Version="2026.10.4" />
<PackageVersion Include="Shared.IntegrationTesting" Version="2026.10.4" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.13" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="10.0.13" />
<PackageVersion Include="coverlet.collector" Version="3.2.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.13" />
<PackageVersion Include="Ductus.FluentDocker" Version="2.85.0" />
<PackageVersion Include="NLog" Version="6.2.2" />
<PackageVersion Include="SecurityService.Client" Version="2026.9.3.199" />
<PackageVersion Include="SecurityService.Client" Version="2026.10.2.200" />
</ItemGroup>
</Project>
131 changes: 0 additions & 131 deletions EstateReportingAPI.BusinessLogic/QueryTimingInterceptor.cs
View file
Open in desktop

This file was deleted.

15 changes: 14 additions & 1 deletion EstateReportingAPI.DataTrasferObjects/CalendarDate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,31 @@
namespace EstateReportingAPI.DataTrasferObjects{
namespace EstateReportingAPI.DataTrasferObjects{
using System;

/// <summary>API data model describing calendar date information.</summary>

public class CalendarDate
{
/// <summary>The date value.</summary>
public DateTime Date { get; set; }
/// <summary>The day of week value.</summary>
public String DayOfWeek{ get; set; }

Check warning on line 11 in EstateReportingAPI.DataTrasferObjects/CalendarDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'DayOfWeek' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
/// <summary>The day of week number value.</summary>
public Int32 DayOfWeekNumber{ get; set; }
/// <summary>The day of week short value.</summary>
public String DayOfWeekShort{ get; set; }

Check warning on line 15 in EstateReportingAPI.DataTrasferObjects/CalendarDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'DayOfWeekShort' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
/// <summary>The month name value.</summary>
public String MonthName{ get; set; }

Check warning on line 17 in EstateReportingAPI.DataTrasferObjects/CalendarDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'MonthName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
/// <summary>The month name short value.</summary>
public String MonthNameShort { get; set; }

Check warning on line 19 in EstateReportingAPI.DataTrasferObjects/CalendarDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'MonthNameShort' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
/// <summary>The month number value.</summary>
public Int32 MonthNumber { get; set; }
/// <summary>The week number value.</summary>
public Int32 WeekNumber { get; set; }
/// <summary>The week number string value.</summary>
public String WeekNumberString { get; set; }

Check warning on line 25 in EstateReportingAPI.DataTrasferObjects/CalendarDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'WeekNumberString' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
/// <summary>The year value.</summary>
public Int32 Year { get; set; }
/// <summary>The year week number value.</summary>
public String YearWeekNumber { get; set; }

Check warning on line 29 in EstateReportingAPI.DataTrasferObjects/CalendarDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'YearWeekNumber' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
}
}
4 changes: 3 additions & 1 deletion EstateReportingAPI.DataTrasferObjects/CalendarYear.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using System;
using System;

namespace EstateReportingAPI.DataTrasferObjects
{
/// <summary>API data model describing calendar year information.</summary>
public class CalendarYear
{
/// <summary>The year value.</summary>
public Int32 Year{ get; set; }
}
}
7 changes: 6 additions & 1 deletion EstateReportingAPI.DataTrasferObjects/ComparisonDate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
namespace EstateReportingAPI.DataTrasferObjects{
namespace EstateReportingAPI.DataTrasferObjects{
using System;

/// <summary>API data model describing comparison date information.</summary>

public class ComparisonDate{
/// <summary>The order value value.</summary>
public Int32 OrderValue{ get; set; }
/// <summary>The date value.</summary>
public DateOnly Date { get; set; }
/// <summary>The description value.</summary>
public String Description { get; set; }

Check warning on line 12 in EstateReportingAPI.DataTrasferObjects/ComparisonDate.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'Description' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
}
}
Loading
Loading