Skip to content

Standardise reporting dates and times (#595) - #615

Merged
StuartFerguson merged 2 commits into
mainfrom
task/#595_standardise_date_and_time_handling
Sep 30, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
task/#595_standardise_date_and_time_handling

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

Implements the reporting date and time handling changes for #595.

  • Centralises reporting time handling through an injectable TimeProvider.
  • Treats reporting dates as UK-local business dates using Europe/London.
  • Changes public report date inputs and business-date outputs to DateOnly.
  • Changes public report timestamps to DateTimeOffset with the correct UK offset.
  • Applies inclusive caller date ranges with exclusive internal end boundaries.
  • Updates the shared DTO/client contract and affected integration test request models.
  • Adds deterministic tests covering UK midnight and GMT/BST behaviour.

Estate-specific timezones remain out of scope; this change retains the service-wide UK timezone policy.

Verification

  • dotnet build EstateReportingAPI.sln --no-restore -v minimal ✅
  • dotnet test EstateReportingAPI.BusinessLogic.UnitTests\\EstateReportingAPI.BusinessLogic.UnitTests.csproj --no-restore -v minimal ✅ 94 passed
  • Client project build ✅
  • Full integration execution could not run in this Windows environment because the test containers require a Linux Docker engine.

Closes #595

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@StuartFerguson StuartFerguson linked an issue Sep 30, 2026 that may be closed by this pull request

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3fff4ec588

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize report date and timezone handling

1 participant