Repository navigation
Update NuGet packages and share SQL Server across integration tests #584
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| using System; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using Shared.IntegrationTesting; | ||
| using Shared.IntegrationTesting.TestContainers; | ||
| using Shared.Logger; | ||
| using NLog; | ||
|
|
||
| namespace EstateReportingAPI.IntegrationTests; | ||
|
|
||
| internal sealed class IntegrationTestEnvironment | ||
| { | ||
| private static readonly SemaphoreSlim InitialisationLock = new(1, 1); | ||
| private static IntegrationTestEnvironment? Instance; | ||
|
|
||
| private IntegrationTestEnvironment(TestDockerHelper dockerHelper, int sqlPort) | ||
| { | ||
| this.DockerHelper = dockerHelper; | ||
| this.SqlPort = sqlPort; | ||
| } | ||
|
|
||
| public TestDockerHelper DockerHelper { get; } | ||
|
|
||
| public int SqlPort { get; } | ||
|
|
||
| public static async Task<IntegrationTestEnvironment> GetAsync() | ||
| { | ||
| if (Instance != null) | ||
| { | ||
| return Instance; | ||
| } | ||
|
|
||
| await InitialisationLock.WaitAsync().ConfigureAwait(false); | ||
| try | ||
| { | ||
| if (Instance != null) | ||
| { | ||
| return Instance; | ||
| } | ||
|
|
||
| string scenarioName = "IntegrationTests"; | ||
| NlogLogger logger = new(); | ||
| logger.Initialise(LogManager.GetLogger(scenarioName), scenarioName); | ||
| LogManager.AddHiddenAssembly(typeof(NlogLogger).Assembly); | ||
|
|
||
| TestDockerHelper dockerHelper = new(); | ||
| dockerHelper.Logger = logger; | ||
|
|
||
| await dockerHelper.StartContainersForScenarioRun(scenarioName, DockerServices.SqlServer); | ||
|
|
||
| int sqlPort = dockerHelper.GetSqlPort() | ||
| ?? throw new InvalidOperationException("SQL Server container did not expose port 1433."); | ||
|
|
||
| Instance = new IntegrationTestEnvironment(dockerHelper, sqlPort); | ||
|
There was a problem hiding this comment.
When an integration-test process finishes, this static instance remains the sole owner of the Docker helper, but no assembly-level or process-level teardown calls Useful? React with 👍 / 👎. |
||
| return Instance; | ||
| } | ||
| finally | ||
| { | ||
| InitialisationLock.Release(); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each test creates a GUID-named database through
EnsureCreated, but xUnit invokes thisIAsyncLifetime.DisposeAsyncmethod rather than the separateDispose()method below, so making it a no-op leaves all 47 per-test databases in the shared SQL Server for the remainder of the run. Invoke the existing database cleanup (and dispose the client, factory, and context) here so a full suite does not continually accumulate databases and connections.Useful? React with 👍 / 👎.