Skip to content

Fix duplicate login route handling - #1156

Merged
StuartFerguson merged 2 commits into
mainfrom
bug/#1155_duplicate_login_route
Sep 15, 2026
Merged

StuartFerguson merged 2 commits into
mainfrom
bug/#1155_duplicate_login_route

Conversation

@StuartFerguson

Copy link
Copy Markdown
Member

Summary

  • Move the live authentication challenge route from /login to /authentication/login.
  • Keep /login as the UI page and show test credentials only when test mode is enabled.
  • Add coverage confirming both login routes are registered exactly once.

Testing

  • Added an endpoint registration test for the live login configuration.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f6f1dbfc3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@StuartFerguson
StuartFerguson merged commit 0484c52 into main Sep 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate GET /login endpoints cause AmbiguousMatchException locally

1 participant