fix(connector): stop first-come /link owner takeover across chat adapters - #1320
Open
DHDHLZ wants to merge 1 commit into
Open
fix(connector): stop first-come /link owner takeover across chat adapters#1320DHDHLZ wants to merge 1 commit into
DHDHLZ wants to merge 1 commit into
Conversation
…ters Each messaging adapter (Telegram, Discord, Slack, Feishu) bound the first caller of /link as owner when none was configured. Because bots are publicly reachable, whoever messages /link during the unlinked setup window becomes the owner and inherits owner-gated surfaces (inbox, desk issues, UTA review actions). Now /link only binds a chat for the owner pre-configured in Connector settings; an unconfigured connector refuses to bind and explains the requirement. Regression specs cover refuse-when-unconfigured, bind-for-configured-owner, and reject-non-owner.
|
@DHDHLZ is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix: messaging adapters bound the FIRST caller of /link as owner
when none was configured (Telegram, Discord, Slack, Feishu all shared the
same first-come logic).
Impact: bots are publicly reachable, so during the unlinked setup window
whoever messages /link first becomes the owner and inherits every
owner-gated surface (inbox, desk issues, and the UTA review/push actions).
Change:
Connector settings (ownerUserId).
so there is no anonymous first-come path.
Tests:
configured-owner, reject-non-owner (36 connector adapter tests pass);
configured-owner contract;