fix(media): contain media file resolution inside the store (CWE-22 path traversal) - #1319
Open
DHDHLZ wants to merge 1 commit into
Open
fix(media): contain media file resolution inside the store (CWE-22 path traversal)#1319DHDHLZ wants to merge 1 commit into
DHDHLZ wants to merge 1 commit into
Conversation
GET /api/media/:date/:name joined URL segments into the media path without a containment check. Hono percent-decodes route params, so ..%2F.. sequences escaped MEDIA_DIR and read arbitrary files readable by the Alice process (e.g. data/config/auth.json, data/config/accounts.json). Add a path fence in resolveMediaPath (reject any result outside MEDIA_DIR), restrict the route to known media extensions, and cover both with regression specs.
|
@DHDHLZ is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix: GET /api/media/:date/:name allowed arbitrary file disclosure.
What: URL segments were joined into the media path without a containment
check; Hono percent-decodes route params, so a request such as
GET /api/media//..%2F..%2Fconfig%2Fauth.json read files outside the
store (auth.json, accounts.json with broker credentials, and any file
readable by Alice).
Fix:
Verified: