feat(amsg-server): abort cancelled fire generation and tools - #90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling or superseding a running task previously stopped future pushes only after lease renewal; the in-flight LLM request and tool loop could continue. Lease loss now aborts the active request and exposes
signal,isCancelled()andthrowIfCancelled()to fire hooks. Cancelled fires settle withstatus: 'cancelled'andwillRetry: false, and an outbox write racing cancellation removes its undelivered results after committing.The existing heartbeat interval stays unchanged. Interactive applications can use
leaseHeartbeatMs: 1000and pass the signal into their tools; completed external side effects remain irreversible.Validation:
npm run cipassed (1,335 tests across all six packages), including cancellation during model requests, before/output hooks, tools, swallowed tool errors, outbox commit, and rejected state writes after cancellation while settlement cleanup stays available. Changesets publishes shared/server and updates dependent package ranges on the next prerelease train.