Harden landing page accessibility and feature cards - #3
Merged
Conversation
fepegar
changed the title
There was a problem hiding this comment.
Pull request overview
This PR strengthens the TorchIO landing page’s accessibility and progressive enhancement, and introduces automated static checks plus a tighter GitHub Pages deployment artifact.
Changes:
- Add a Python-based static site checker (HTML semantics/anchors, image metadata, CSS safeguards, asset budget, optional external link validation) and wire it into local
misetasks and CI. - Improve landing page accessibility/no-JS behavior (skip link,
<main>landmark, reveal gated by.js, live region updates, safer clipboard handling, and more consistent decorative SVG attributes). - Narrow the GitHub Pages artifact to only the public site files under
_site/.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/check_site.py | New static checker for local structure, assets, and (optionally) external links. |
| README.md | Document local serving via mise and the new check tasks. |
| mise.toml | Add check / check:links tasks to run the site checker. |
| index.html | Accessibility + progressive enhancement updates (skip link, <main>, logo assets, SVG attributes, aria-live updates). |
| assets/js/main.js | Harden clipboard behavior, add aria-live status updates, add // @ts-check and typings, improve augmentation switching. |
| assets/css/styles.css | Add focus-visible outline, skip-link + visually-hidden utilities, gate reveal animations behind .js, tweak contrast. |
| .gitignore | Ignore generated _site/ and copilot_log.md. |
| .github/workflows/deploy.yml | Build a minimal _site/ artifact before uploading to GitHub Pages. |
| .github/workflows/checks.yml | Add CI job to run the site checker (currently with external link checks enabled). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Generated by a coding agent]
Summary
Validation
uv run python scripts/check_site.py --externalmise run checkmise run check:linksnode --check assets/js/main.jsgit diff --check