Repository navigation
ci: consolidate hosted gates and exact full qualification - #435
Merged
Merged
Conversation
jonit-dev
marked this pull request as ready for review
October 4, 2026 21:48
This was referenced Oct 5, 2026
jonit-dev
added a commit
that referenced
this pull request
Oct 5, 2026
The cleanup PR's qualification is green and #435 merged as abaa1f0: PR run 37256579927 (65 succeeded, 1 expected policy skip, ci-required success) and merge-group run 37259374897 (66 jobs, 13 template nonvisual legs, 3 golden-path jobs, 16 Integration jobs, ci-required success) both pass, so the last open Phase 2 box is ticked with no bypass. PRD-483 had no Acceptance criteria section, so prd-progress could never report it ready. Its four outcome criteria are written from the landed evidence and the six CI-contract specs (282 tests) that guard them. The file moves to docs/PRDs/done/ per docs/PRDs/AGENTS.md; the AGENTS.md link follows and CLAUDE.md is regenerated. `pnpm prd:progress` reads prd:100% — ready. Co-authored-by: Joao Paulo Furtado <jfurtado141@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge candidates currently receive reduced native/template coverage, and Integration failures do not independently join the sole required verdict. This change makes queue, main and audit qualification exhaustive at the exact candidate SHA: all 13 templates, both goldens, full supported native coverage and retained Integration.
ci-requiredindependently rejects narrowed plans, missing/skipped/cancelled required legs, stale attempts and wrong source/candidate identities.Ordinary PRs retain affected coverage and Android. The existing iOS advisory policy remains explicit. Full-tree verdict reuse stays disabled. Each hosted template leg proves pristine compiler coverage before its scenarios, with conservative fallback for local or unknown inputs. Producer repairs bind Android compiler objects and effective O2 through merged/stripped/executed APK bytes; Windows source normalization accepts only literal CRLF-to-LF equality with the exact candidate. Measured C++ coverage inputs and floors were not restamped. The absorbed #436 browser gate retirement retains CPU, collision, native and scenario coverage with strict receipts.
The remaining Windows failure was the workload's full warmup advance running before game startup readiness. The shared device/desktop runner now completes its existing startup gate, then executes every scenario warmup tick before sampling. Setup, opt-out/no-startup behavior, readiness requirements, workload/performance assertions and deadlines remain unchanged. A post-readiness timeout still fails. Warmup accounting also uses deadlines established before compiler invocation; it cannot interrupt synchronous work. Failed-host console and bounded pending-request evidence remain available before cleanup.
Validation:
e072c3a65b80fdf2437dc25ef3f7277c60c7d75e, based on current develop64aed30.03399e33/candidatef63dbf97, had 62 successes and only Windows workload as a root failure; required joins rejected it correctly. Android, unit3, release packaging and clean-source proof passed. Its failed workload timed out advance3 before startup readiness; the separate startup arm passed after compilation at 33.525s and readiness at 43.814s.Published PR qualification 37256579927 passed: 65 successful jobs/one expected policy skip, including
ci-required. Windows produced 26 qualified samples over 14.1s with all three required markers and no binding error codes; its declared software performance advisory remains visible. Normal queue enrollment is confirmed, position 1. Queue 37259374897 tests exact candidatec3211d3con documentation-only updated base0863d102, with full native/all 13 templates/both goldens/required Integration. Queue qualification and actual merge remain pending.Original PRD-483 completion: 100% (5/5 phase acceptance criteria verified). Its final unchecked criterion, normal PR CI passing before merge, is proved by run37256579927 attempt1 (65 success/one expected policy skip,
ci-requiredsuccess) on sourcee072. Queue run37259374897 remains active only in Linux native fog correctness; every other retained test/template/native/unit lane has passed. Full native receipts explicitly retain the iOS advisory failure and certify no iOS qualification. Windows production is functional PASS; software performance remains advisory. This evidence does not prove a worst-case genuinely cold queue within the 120-minute response window, defer Android, enable verdict reuse or complete #430’s separate rollout. The canonical PRD checkbox/status will be reconciled immediately after normal merge without invalidating the active candidate.Merged at 2026-10-05 04:38:29 UTC, commit abaa1f0. The user explicitly authorized dequeue and the existing override after repeated external target advances; the merge used an exact source-head guard on e072. The earlier exhaustive queue run37259374897/c321 passed in66m37s. The latest regenerated candidate4ffade06/run37263424116 had not completed full qualification before override; no green verdict is claimed for that tree. No protection/settings/timeout changes or force push were made.