Repository navigation
Conversation
Remove the scratch-file dependency while retaining exact candidate, hash, current authority and configured execution context checks. Keep log contents out of durable worker metadata. Fixes ThinkFlowLab#2519.
zy95-12
marked this pull request as ready for review
November 5, 2026 11:41
zy95-12
merged commit Nov 5, 2026
e11ba3b
into
ThinkFlowLab:delivery/ai-centric-development-service
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Codex
Fixes #2519
SDK Reviewers previously received only a scratch path for host-test evidence. Deliver the complete hash-verified UTF-8 log inline instead, preserving the current candidate, artifact identity, live authority, 2 MiB cap and existing configured context preflight. Keep only provenance metadata in durable worker records; candidate permissions and Agent routing stay unchanged.
Validation at 42d28f9: 14 artifact regressions and 2 actual subprocess dispatch cases pass. An opt-in actual pinned Codex SDK/CLI case passes with a local Responses fixture: content reaches the provider with no receiving log file and source writes remain denied. Artifact helper coverage: 100% lines/functions, 93.55% branches; not whole-change/exhaustive branch coverage (uncovered inherited missing-attempt-map and missing-hash fallback paths). The absent inline channel fails on fetched base 5ca3486; isolated hidden-scratch reads themselves passed, so no universal onsite sandbox cause is claimed.
Final root
TZ=UTC setpriv --bounding-set=-dac_override,-dac_read_search npm run verify: 5,088 passed / 0 failed / 0 skipped, including 8 actual disposable DSH scenarios. Exact-head Node 24 and tests-ok passed in run 42019929932. OpenAPI generation and 10 focused API checks pass; only implementation fingerprints changed. Historical implementation notes are archived verbatim to retain the unchanged 384,000-byte role-policy cap and complete required source set. Memory, dated decision, Harness/GitHub architecture, role guide, changelog and canonical patches included. Standing Owner delivery-branch basic-CI scope applies; live target branch rules are empty. The advisory enqueue guard still asks for an independent Verifier report; none is fabricated. This delivery follows the Owner-authorized basic gate, with main gates unchanged.Not run: production deployment/restart, live OpenToday replay, paid model inference or private installed-App acceptance. The 2 MiB artifact cap does not guarantee a log fits every configured model window; oversized execution input refuses before SDK dispatch rather than truncating evidence or raising limits.