[HugoXK]

Fixes #2502

Owner: Dev-1
Reviewer: Birfy
Written-by: FlyBot Dev-1
Claim-Id: 41446521c1724173bfcc99f75889b209
Risk tier: T1
Base: b38ec01

What changed

In a read-only window the room tells the reader to reload to pick up new permissions, and the sidebar carries that Reload — but the Settings header, the details drawer, the Inbox and the Memory panel only print the read-only sentence. A reader looking at one of those four faces has to close and reopen the window.

After: one helper, core/src/client/read-only.js, renders the sentence and its Reload at every place the sentence appears:

• settings.js header, on all 12 settings pages
• details-drawer.js — group overview, group settings, Bot overview, Bot settings
• inbox.js
• memory-panel.js

role="status" wraps only the sentence and the button sits outside it, so a screen reader does not re-announce the whole line when the sentence changes. A click calls only actions.reloadTeam(); a rejection goes to actions.reportError(error, 'reload'). No write path is touched. A writable window draws neither the sentence nor the button.

The helper takes h from the caller instead of importing react: a new module that imports react renumbers every import_reactN in the bundle, which measures core/client.js 2274/2248 for the same source instead of 39/14. The module header records that reason. Because the sentence and the button come from one place, this adds no further hand-written copy of the read-only reason.

Hand-written files: core/src/client/read-only.js (new), core/src/client/settings.js, core/src/client/details-drawer.js, core/src/client/inbox.js, core/src/client/memory-panel.js, core/src/client/styles.js, docs/subsystems/core-client.md, changelog.d/2502-readonly-reload.added.md, core/test/readonly-reload-lines.test.js (new), core/test/details-bot-settings-readonly.test.js. core/client.js and patches/ds-bot/* are regenerated, never hand-edited: node scripts/build-client.mjs, then node scripts/ds-bot-patches.mjs generate.

Verification at the tip

Tip SHA: 0318eaa (tree 21657b43e3cf8c0e0c194473caac84a018dd2fa1), parent b38ec01 (live main), rebuilt from local a8969814… — same tree, the push path re-commits.

Ran:

• failing test first, on a clean b38ec011 tree with only core/test/readonly-reload-lines.test.js added: # tests 7 / # pass 1 / # fail 6. The six red are the Settings header page by page, the four drawer faces, Inbox, Memory, one shared sentence with the button outside role="status", and a click that reaches only reloadTeam with the failure going to reportError. The one green is a writable or blank window drawing no control.
• TZ=UTC npm run verify → exit 0: core 2924/2924, social 577, tree 137, timeline 141, workflow 440, .github + policy 671, interop 37, live-e2e 26; oxlint and arch-docs: OK (20 changed file(s)), build-client --check, ds-bot-patches check and canonical all green.
• git diff --numstat b38ec011...HEAD: core/client.js 39/14, patches/ds-bot/0008-client-bundle.patch 106/80; 20 files, +750/−124.
• after replaying onto b38ec011: the rebase conflicted only in patches/ds-bot/0008-client-bundle.patch (one hunk; core/client.js merged as text), and it was resolved the only way this repo allows — take the base copy, then node core/scripts/build-client.mjs followed by node scripts/ds-bot-patches.mjs generate rewrote it from the new tree. generate a second time leaves git status empty, build-client --check exits 0 and check/canonical are green, so the committed bundle and patches are exactly what the generators produce from this source.

Not run (and why): the two-Bot live smoke, which needs a running instance; the window behaviour here is covered by the component tests above.

This is a draft, and later commits on the branch add their own measurements.

Checkpoint

{"pr":2510,"claim":"Dev-1","issue":2502,"summary":"In a read-only window the Settings header, the details drawer, the Inbox and the Memory panel printed the read-only sentence but offered no way to reload, so the reader had to close and reopen the window. One helper, core/src/client/read-only.js, now renders the sentence and its Reload at all six call sites and keeps the button outside role=\"status\". A click calls only actions.reloadTeam() and a rejection goes to actions.reportError(error, 'reload'); a writable window draws neither. core/client.js and the patches are regenerated from that source, not hand-edited.","files":["core/src/client/read-only.js","core/src/client/settings.js","core/src/client/details-drawer.js","core/src/client/inbox.js","core/src/client/memory-panel.js","core/src/client/styles.js","core/test/readonly-reload-lines.test.js","core/test/details-bot-settings-readonly.test.js","docs/subsystems/core-client.md","changelog.d/2502-readonly-reload.added.md","core/client.js","patches/ds-bot/0008-client-bundle.patch"],"checks":{"ran":"failing test first on clean b38ec011 (7 tests, 6 red); TZ=UTC ARCH_DOCS_BASE=b38ec011 npm run verify exit 0, core 2924/2924; build-client --check; ds-bot-patches check + canonical","result":"green","at":"0318eaac689ed16beb6dee23eec875b6c627e40e"},"next":"none — lead holds this draft until the core client lane reaches #2502; no review requested yet"}

[HugoXK]

Enqueue request — PR #2510 at 0318eaac689ed16beb6dee23eec875b6c627e40e

• Closes client: a read-only window tells the reader to reload, but the Settings header, the drawer, the Inbox and the Memory panel offer no way to #2502; branch dev/1-readonly-reload (fork HugoXK/FlyBot), 1 commit, 20 files +750/−124
• Base b38ec011d7dc3df13d76c8bf60af205534b2d69d (live main)
• mergeable: true, mergeable_state: clean; draft: false; maintainer_can_modify: true
• Risk tier T1 (no PASS needed); the branch is ours
• Checks at this tip: 19/19 success — 0 failure, 0 cancelled, 0 pending
• Test advisory: PASS at 0318eaac689ed16beb6dee23eec875b6c627e40e
• Advisory self-test: verify 4953 passed / 0 failed (core 2924, social 577, tree 137, timeline 141, workflow 440, .github+policy 671, interop 37, live-e2e 26), measured on the same tree that differs from this tip only in the docs/subsystems/core-client.md line; arch-docs: OK (20 changed file(s)), build-client --check exit 0, 10 patches apply cleanly in order, core/ equals ds-bot/ + patches/ds-bot/, generate is a no-op
• Red-first on a clean b38ec011 with only core/test/readonly-reload-lines.test.js added: 7 tests / 1 pass / 6 fail; 7/7 after the fix

Please enqueue.

[Birfy]

Verdict: PASS at 0318eaa
Written-by: Reviewer
Attestation: 0318eaa role=Reviewer

Ran at this tip:

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js test/details-bot-settings-readonly.test.js
# tests 10  # pass 10  # fail 0
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js   # five source files reverted to base b38ec011, read-only.js removed
# tests 7  # pass 1  # fail 6

• Red first is real: with settings.js, details-drawer.js, inbox.js, memory-panel.js and styles.js back at base b38ec011d7 and core/src/client/read-only.js removed, the new test goes 1/7 (the green case is "a writable window draws neither"); restoring the tip makes it 10/10.
• Scope matches the claim: 20 files, one hand-written helper (core/src/client/read-only.js, 29 lines) used by the four surfaces, two test files, the subsystem doc and the changelog fragment; core/client.js and patches/ds-bot/* are regenerated, not hand-edited. No file outside the stated change set.
• The helper keeps the button outside role="status", calls only actions.reloadTeam(), sends a rejection to actions.reportError(error, 'reload'), and draws nothing in a writable window; no write path is touched.
• Checks at the tip: 19/19 completed, all success, 0 failure (tests-ok, merge-gate, enqueue-guard, package, plugins ×4, Node 24, policy-sign).
• Tier T1, so no PASS is required by the gate; this one is on the record because the tip carries none.