pass-label: match a PASS writer against the roster the way the gates do #2544

Activity

1. HugoXK commented on Nov 5, 2026

   

   HugoXK

   on Nov 5, 2026

   ContributorAuthor

   More actions

   Claim-Id: a91e62dd206541bbab9c6e2898d04642
   Branch: dev/4-pass-label-writer-case
   Base: main (d400edb74798b71e233eccd46f221eaef782ff5d)

   Flight plan: one PR (Fixes #2544) from dev/4-pass-label-writer-case, ready, maintainer_can_modify: true, red-first evidence in the body. Bug, T2 (.github/scripts/** + changelog.d/**).
2. HugoXK commented on Nov 5, 2026

   

   HugoXK

   on Nov 5, 2026

   ContributorAuthor

   More actions

   Written-by: FlyBot Lead

   Evidence for the maintainers, left here because we are not changing a gate file today: #2547 was frozen at bc0e72eb07df045bdbe1232a5c870e8eca41f765 and its body no longer asks for a signature. Everything below is read from live main (276042f828bbf21716d93e1901619eab9f4e794c) as it stands.

   The asymmetry, three sites:

   // .github/scripts/pass-label.mjs:45 — case-sensitive, on the array from review-policy.json
   if (!report.writer || !writers.includes(report.writer)) return null
   
   // .github/scripts/review-gate.mjs:77-85 — the gates lowercase both sides
   const reviewers = new Set((policy?.reviewers ?? []).map((l) => String(l).toLowerCase()))
   const key = name.toLowerCase()
   if (!name || !reviewers.has(key)) continue
   
   // .github/scripts/pass-label.mjs:74-75 — the stranger path lowercases too
   const listed = new Set(writers.map((w) => String(w).toLowerCase()))
   if (listed.has(String(report.writer).toLowerCase())) return null

   So a report written Written-by: reviewer (or dev4) against a roster entry Reviewer is a conclusion for review-gate and merge-gate, but verdictOf returns null — no pass label and no comment — while strangerPassOf calls the same name listed and stays silent. #739 promises the pass record in exactly the case that goes quiet here.

   Red first (clean base, only the new case in .github/scripts/pass-label.test.mjs):

   not ok 3 - #739: a writer matches the way the gates match it, whatever its case
     error: 'reviewer is a listed name in another case'
     expected: true
     actual: ~
   # tests 12 / # pass 11 / # fail 1
   

   Fixed locally: pass-label.mjs +3/−2 (one isListedWriter(writers, name) used by both paths), test +16/−0, .github/scripts suite 669/669, negative controls reviewer3 and Reviewer Extra still null.

   Why it is not in our pull request: .github/scripts/pass-label.mjs is a gate file in policy/gates.json, so policy-sign refuses a change to it without a signed comment from another person naming the tip — its own words on #2547: policy-sign refused (#2547): a gate file changed (.github/scripts/pass-label.mjs), and the body carries no 'Policy-sign:' line naming a comment. That signature is the maintainers' decision, not ours to arrange inside a sprint; the change belongs in your file, with the roster test you already keep.

   The local branch dev/4-pass-label-writer-case and the PR #2547 stay as they are (frozen, not merged); nothing is pushed further and no workflow is asked for.