bug(workflow): a valid definition is refused as edge/misaligned when one fact is spelled with a space on the node and without one on its edge #2425

Written-by: Delivery-1

validateWorkflow refuses a valid workflow as edge/misaligned when one fact is spelled with a space on a node and without one on an edge — although every other rule in the engine keys that fact by its parsed spec, so the definition is runnable.

Reproduce (base delivery/ai-centric-development-service @ 5e71a07)

The producer spells the fact text: draft; the consumer and the edge spell it text:draft:

cd core && node -e "
import('./src/shared/workflow.js').then(m => {
  const def = {
    id: 'draft-publish', name: 'Draft and publish', version: 1,
    inputs: [], deliverables: ['link:published'],
    nodes: [
      { id: 'draft',   name: 'Draft',   role: 'Writer',    outputs: ['text: draft'] },
      { id: 'publish', name: 'Publish', role: 'Publisher', inputs: ['text:draft'], outputs: ['link:published'] },
    ],
    edges: [{ from: 'draft.text:draft', to: 'publish.text:draft' }],
    loops: [],
  };
  console.log(JSON.stringify(m.validateWorkflow(def).problems, null, 2));
});
"

Actual:

[{ "code": "edge/misaligned",
   "message": "the edge \"draft.text:draft -> publish.text:draft\" does not line up: \"draft\" does not hand out \"text:draft\" or \"publish\" does not take it in" }]

Expected: ok: true, no problem — canonicalSpec already makes text: draft and text:draft one fact (#1291 debt, #1298), and the same definition runs: dependencyEdges gives draft → publish, enterNode('publish', …) is ok: true once the text:draft artifact is present and current. Flipping which side carries the space (from: 'draft.text: draft', consumer text:draft) is refused the same way.

Where

core/src/shared/workflow.js:637 — the alignment check compares the edge's canonical artifact (splitEndpoint returns formatArtifactSpec) against the node's raw inputs / outputs arrays with Array.prototype.includes. Every other consumer/producer rule in the file (producersOf, consumersOf, dependencyEdges, input/without-producer, output/without-consumer) reads those lists through canonicalSpec, so this one check disagrees with the rest of the engine. The edge/crossed-artifacts branch below it is fine (both sides are canonical there).

User impact

The Workflows page saves through workflow-store.js (core/src/host/workflow-store.js:135), which returns workflow/invalid with problems[0].message, and the client renders that message (core/src/client/workflows.js:31). So a user who writes one fact with a space on a node and without one on its edge cannot save a definition the engine can run, and the refusal it shows is false.

Red first

core/test/workflow-edge-spec.test.js (2 tests) on the base above: # tests 2 / # pass 1 / # fail 1 — the mixed-spelling test fails with the edge/misaligned problem quoted above; the genuinely-crossed control test passes. With the source change both pass: # tests 2 / # pass 2 / # fail 0.