Repository navigation
feat(ai): upgrade Claude, GPT, and Gemini models - #850
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Claude Sonnet model name and gateway identifier now use version 5.5. The fallback lists, telemetry example, routing comment, and fallback test were updated to reflect the change. ChangesSonnet model update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated Sonnet selection and fallbacks use a model identifier listed by the gateway; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/workspaces/ai/ai-gateway-routing.ts">
<violation number="1" location="src/features/workspaces/ai/ai-gateway-routing.ts:46">
P2: Custom agent: **Flag AI Slop and Fabricated Changes**
This routing change is not covered by a test: the updated observability fixture uses hand-built metadata and never calls `getWorkspaceAiGatewayRoutingOptions`. Add a regression assertion for the `gpt-terra` and `gemini-pro` fallback model lists.</violation>
</file>
<file name="src/features/workspaces/ai/models.ts">
<violation number="1" location="src/features/workspaces/ai/models.ts:56">
P2: Custom agent: **Flag AI Slop and Fabricated Changes**
Add a regression test for the changed `claude-sonnet` mapping. The observability fixture uses the new slug, but no test verifies that `getWorkspaceAiChatModel("claude-sonnet")` returns `"anthropic/claude-sonnet-5.5"`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| "gpt-terra": { | ||
| order: ["openai", "azure"], | ||
| models: ["anthropic/claude-sonnet-5", "google/gemini-3.1-pro-preview"], | ||
| models: ["anthropic/claude-sonnet-5.5", "google/gemini-3.1-pro-preview"], |
There was a problem hiding this comment.
P2: Custom agent: Flag AI Slop and Fabricated Changes
This routing change is not covered by a test: the updated observability fixture uses hand-built metadata and never calls getWorkspaceAiGatewayRoutingOptions. Add a regression assertion for the gpt-terra and gemini-pro fallback model lists.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/features/workspaces/ai/ai-gateway-routing.ts, line 46:
<comment>This routing change is not covered by a test: the updated observability fixture uses hand-built metadata and never calls `getWorkspaceAiGatewayRoutingOptions`. Add a regression assertion for the `gpt-terra` and `gemini-pro` fallback model lists.</comment>
<file context>
@@ -43,15 +43,15 @@ const workspaceAiGatewayRouting: Record<WorkspaceAiChatModelId, GatewayRoutingOp
"gpt-terra": {
order: ["openai", "azure"],
- models: ["anthropic/claude-sonnet-5", "google/gemini-3.1-pro-preview"],
+ models: ["anthropic/claude-sonnet-5.5", "google/gemini-3.1-pro-preview"],
},
"gpt-luna": {
</file context>
| name: "Claude Sonnet 5", | ||
| gatewayModel: "anthropic/claude-sonnet-5", | ||
| name: "Claude Sonnet 5.5", | ||
| gatewayModel: "anthropic/claude-sonnet-5.5", |
There was a problem hiding this comment.
P2: Custom agent: Flag AI Slop and Fabricated Changes
Add a regression test for the changed claude-sonnet mapping. The observability fixture uses the new slug, but no test verifies that getWorkspaceAiChatModel("claude-sonnet") returns "anthropic/claude-sonnet-5.5".
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/features/workspaces/ai/models.ts, line 56:
<comment>Add a regression test for the changed `claude-sonnet` mapping. The observability fixture uses the new slug, but no test verifies that `getWorkspaceAiChatModel("claude-sonnet")` returns `"anthropic/claude-sonnet-5.5"`.</comment>
<file context>
@@ -52,8 +52,8 @@ export const WORKSPACE_AI_CHAT_MODELS = [
- name: "Claude Sonnet 5",
- gatewayModel: "anthropic/claude-sonnet-5",
+ name: "Claude Sonnet 5.5",
+ gatewayModel: "anthropic/claude-sonnet-5.5",
provider: "anthropic",
tagline: "Thoughtful and polished",
</file context>
 |
urjitc
changed the title
There was a problem hiding this comment.
2 issues found across 7 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/workspaces/ai/gateway.ts">
<violation number="1" location="src/features/workspaces/ai/gateway.ts:136">
P2: Custom agent: **Flag AI Slop and Fabricated Changes**
This model/provider behavior change has no regression assertions. Add tests that verify the `gpt-sol` reasoning option and title model's `minimal` thinking configuration.</violation>
</file>
<file name="src/features/workspaces/extraction/providers/gemini-image-markdown.ts">
<violation number="1" location="src/features/workspaces/extraction/providers/gemini-image-markdown.ts:16">
P2: Custom agent: **Flag AI Slop and Fabricated Changes**
This model and thinking-config change alters the image-extraction request, but no test exercises `createGeminiImageMarkdownProvider` or asserts those fields. Add a focused regression test that mocks `generateText` and verifies the model and provider options.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| openai: { | ||
| reasoningEffort: "none", | ||
| // Sol 6.1 requires reasoning; low is its minimum supported effort. | ||
| reasoningEffort: "low", |
There was a problem hiding this comment.
P2: Custom agent: Flag AI Slop and Fabricated Changes
This model/provider behavior change has no regression assertions. Add tests that verify the gpt-sol reasoning option and title model's minimal thinking configuration.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/features/workspaces/ai/gateway.ts, line 136:
<comment>This model/provider behavior change has no regression assertions. Add tests that verify the `gpt-sol` reasoning option and title model's `minimal` thinking configuration.</comment>
<file context>
@@ -129,10 +129,11 @@ function getWorkspaceAiReasoningOptions(
openai: {
- reasoningEffort: "none",
+ // Sol 6.1 requires reasoning; low is its minimum supported effort.
+ reasoningEffort: "low",
},
};
</file context>
| } from "#/features/workspaces/extraction/types"; | ||
|
|
||
| const IMAGE_EXTRACTION_GATEWAY_MODEL = "google/gemini-2.5-flash"; | ||
| const IMAGE_EXTRACTION_GATEWAY_MODEL = "google/gemini-3.8-flash"; |
There was a problem hiding this comment.
P2: Custom agent: Flag AI Slop and Fabricated Changes
This model and thinking-config change alters the image-extraction request, but no test exercises createGeminiImageMarkdownProvider or asserts those fields. Add a focused regression test that mocks generateText and verifies the model and provider options.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/features/workspaces/extraction/providers/gemini-image-markdown.ts, line 16:
<comment>This model and thinking-config change alters the image-extraction request, but no test exercises `createGeminiImageMarkdownProvider` or asserts those fields. Add a focused regression test that mocks `generateText` and verifies the model and provider options.</comment>
<file context>
@@ -13,7 +13,7 @@ import type {
} from "#/features/workspaces/extraction/types";
-const IMAGE_EXTRACTION_GATEWAY_MODEL = "google/gemini-2.5-flash";
+const IMAGE_EXTRACTION_GATEWAY_MODEL = "google/gemini-3.8-flash";
const jpegMediaType = "image/jpeg";
</file context>
2 participants
ThinkEx was still using older GPT and Gemini models alongside Sonnet 5. This updates the existing model lineup and its fallback routes to the current corresponding models. The original Sonnet 5.5 contribution by @mahruschow is preserved as its own commit; the remaining upgrades are a maintainer follow-up.
Changes
Testing
Review notes