Repository navigation
feat(editor): align web workbench theme and chrome - #6
Merged
Merged
Conversation
sjungwon03-ai
approved these changes
Sep 27, 2026
sjungwon03-ai
left a comment
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review summary
Verdict: Approved
- Reviewed: editor theme persistence, theme tokens, layout chrome, and accessibility labels
- Checks: all reported CI checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone web editor now supports a persisted light/dark choice with system preference as the initial default. Its panel, button, timeline, and asset colors use theme tokens, and its header and panel geometry align with the host workbench used by OpenScene. Editing models and export behavior are unchanged.\n\nVerification: TypeScript check, 13 editor tests, web production build, and Electron screenshots of both theme states. Tracked by Theorvane/OpenScene#470.