Repository navigation
Conversation
TheOnlyZac
requested changes
Oct 26, 2026
TheOnlyZac
left a comment
TheOnlyZac
left a comment
Owner
There was a problem hiding this comment.
Took a quick look over everything except sb.c and ub.c, I'll have to come back for those later.
| /* 0x00 */ VTCAMSEN *pvtcamsen; | ||
| /* 0x00 */ VTPRSEN *pvtprsen; | ||
| /* 0x00 */ VTEXPL *pvtexpl; | ||
| /* 0x00 */ struct VTSTEPGUARD *pvtstepguard; |
Owner
There was a problem hiding this comment.
Replace struct VTSTEPGUARD with just VTSTEPGUARD.
Comment on lines
+183
to
+223
| static inline void NormalizeVector(VECTOR *pvecOut, const VECTOR *pvecIn, const VECTOR *pvecDefault) | ||
| { | ||
| asm ( | ||
| ".set push\n" | ||
| ".set noreorder\n" | ||
| ".set noat\n" | ||
| "lqc2 $vf3, %1\n" | ||
| "vmul.xyz $vf1, $vf3, $vf3\n" | ||
| "vaddw.x $vf2, $vf0, $vf0w\n" | ||
| "vadday.x ACC, $vf1, $vf1y\n" | ||
| "vmaddz.x $vf1, $vf2, $vf1z\n" | ||
| "lui $1, (0x38D1B717 >> 16)\n" | ||
| "ori $1, $1, (0x38D1B717 & 0xFFFF)\n" | ||
| "mtc1 $1, $f1\n" | ||
| ".word 0x4A0103BD\n" | ||
| "vwaitq\n" | ||
| "vaddq.x $vf1, $vf0, Q\n" | ||
| "lq $4, -16+%1\n" | ||
| "qmfc2.ni $3, $vf1\n" | ||
| "addiu $2, $2, %%lo(g_normalX)\n" | ||
| "mtc1 $3, $f0\n" | ||
| "lq $2, 0($2)\n" | ||
| "c.lt.s $f0, $f1\n" | ||
| "addiu $3, $0, 6\n" | ||
| "sq $4, 16+%0\n" | ||
| "bc1f 1f\n" | ||
| "sw $3, -16+%0\n" | ||
| "b 2f\n" | ||
| "qmtc2.ni $2, $vf1\n" | ||
| "1:\n" | ||
| "vdiv Q, $vf0w, $vf1x\n" | ||
| "vwaitq\n" | ||
| "vmulq.xyzw $vf1, $vf3, Q\n" | ||
| "2:\n" | ||
| "sqc2 $vf1, %0\n" | ||
| ".set pop\n" | ||
| : "=m"(*pvecOut) | ||
| : "m"(*pvecIn), "m"(*pvecDefault) | ||
| : "$1", "$3", "$4", "$f0", "$f1", "memory" | ||
| ); | ||
| } |
| void FUN_001abe70(BLOT *pblot); | ||
|
|
||
| void FUN_001ac060(BLOT *pblot); | ||
| extern "C" void FUN_001ac060(BLOT *pblot); |
Owner
There was a problem hiding this comment.
This function is most likely not C.
Comment on lines
+84
to
+94
| struct EXPL; | ||
| struct EXPLSO; | ||
|
|
||
| /** | ||
| * @brief VT for EXPL objects. | ||
| */ | ||
| struct VTEXPL : VTLO | ||
| { | ||
| void (*pfnExplodeExplExplso)(EXPL *, EXPLSO *); | ||
| }; | ||
|
|
Owner
There was a problem hiding this comment.
Could you move this down below VTALO and VTSO.
| // ... | ||
| /* 0x00 */ GRFEXPLSO grfexplso; | ||
| /* 0x04 */ ALO *paloReference; | ||
| /* 0x08 */ STRUCT_PADDING(2); // padding to 16 bytes for VECTOR |
| struct EXPLO; | ||
| struct EXPLS; | ||
| struct EXPLSO; | ||
| typedef int GRFEXPLSO; |
Owner
There was a problem hiding this comment.
Typedef incorrectly mixed in with forward struct declarations
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ub (Underwater Boss aka Raleigh)
sb (Snow Boss aka Panda King)
sha1sum config/checksum.sha1 out/SCUS_971.98: OK