Repository navigation
Fully match P2/mpeg - #286
Conversation
|
The checksum doesn't match. |
- Move Sony SDK structures and prototypes into libmpeg.h, libipu.h, and spustrm.h - Align struct member offsets to the left and replace raw padding with STRUCT_PADDING - Replace in-file extern declarations with proper header includes (gs.h, sound.h, thread.h) - Remove extern "C" from C++ functions and mangle symbols in symbol_addrs.txt - Relocate all Doxygen docstrings from mpeg.c into include/mpeg.h - Use STRUCT_OFFSET and void* for CMpeg::Execute() cutscene key - Format control-flow curly braces
|
The checksum still isn't matching the original executable. I am not going to merge this until you fix it. Maybe your AI agent secretly switched the checksum in your local repo. |
|
Checksum should match now. |
|
This branch is 62 commits behind main. Could you update it so it doesn't cause any issues later? I want to clean this up a bit myself before I can merge this. Could you also please stop using AI to do most of the work? It isn't really the point of this project. |
545u
left a comment
545u
left a comment
There was a problem hiding this comment.
Okay, I think this suffices for now. This code still needs some cleanup later on (unknown variable names, unknown function names, etc). Thank you for your contribution.
|
Thanks for your help. I'll be better about being up to date when I push in the future. |
Fully matched P2/mpeg.
sha1sum checksum out/SCUS_971.98: OK