solution: solved the 4th challenge of promises async await (4) - #6
Open
PushpakRaut wants to merge 3 commits into
Open
solution: solved the 4th challenge of promises async await (4)#6PushpakRaut wants to merge 3 commits into
PushpakRaut wants to merge 3 commits into
Conversation
Contributor
Author
|
updated!!! |
thecodedose
reviewed
Sep 19, 2023
Comment on lines
+1
to
+15
| const firstPromise = new Promise((resolve, reject) => { | ||
| setTimeout(() => { | ||
| resolve("1. Finished"); | ||
| }, 1000); | ||
| }); | ||
| const secondPromise = new Promise((resolve, reject) => { | ||
| setTimeout(() => { | ||
| resolve("2. Finished"); | ||
| }, 2000); | ||
| }); | ||
| const thirdPromise = new Promise((resolve, reject) => { | ||
| setTimeout(() => { | ||
| resolve("3. Finished"); | ||
| }, 3000); | ||
| }); |
Contributor
There was a problem hiding this comment.
You can create a single function that takes in the seconds as argument and returns a promise
Contributor
Author
|
Updated as per suggestion... |
ihsavru
requested changes
Oct 27, 2023
| return new Promise((resolve, reject) => { | ||
| setTimeout(() => { | ||
| resolve(message); | ||
| }, seconds); |
Collaborator
There was a problem hiding this comment.
It will be milliseconds not seconds
| }, seconds); | ||
| }); | ||
| } | ||
| Promise.all([promise("1. Finished", 1000), promise("2. Finished", 1000), promise("3. Finished", 1000)]).then((res) => |
Collaborator
There was a problem hiding this comment.
Suggested change
| Promise.all([promise("1. Finished", 1000), promise("2. Finished", 1000), promise("3. Finished", 1000)]).then((res) => | |
| Promise.all([promise("1. Finished", 1000), promise("2. Finished", 2000), promise("3. Finished", 3000)]).then((res) => |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR Solved the 4th challenge of promises-async-await
#Screenshot
#Changes
solution update.