fix(init): debug log whoami fallback#223
Open
Lexiie wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughModifies error handling in runInit's whoami step to log a debug message when the identity lookup fails and debug mode is enabled, while retaining the existing placeholder fallback. Adds a corresponding unit test verifying stderr output and JSON stdout integrity. ChangesInit Debug Logging
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resubmission of #209 after the release-process hiccup closed it without merge.
Covers one
src/commands/init.tscatch path from #186.After
setupsuccessfully configures credentials, it runs a display-onlywhoamilookup to fill the final summary. If that lookup fails, setup intentionally continues with a placeholder summary. That behavior is fine, but the failure was completely silent, so--debugusers could not tell why the summary fell back to no email / production / empty scopes.This PR keeps default output and exit behavior unchanged, but emits a debug-only stderr line when the display-only identity lookup fails.
Changes
runWhoamierror inrunInit.[debug] setup identity lookup failed after configure: ...only when--debugis set.Verification
rtk vitest run src/commands/init.test.ts -t "debug log whoami fallback|whoami fallback|debug"rtk npx eslint src/commands/init.ts src/commands/init.test.ts --fix-dry-run --format stylishrtk npx eslint src/commands/init.ts src/commands/init.test.tsrtk npm run typecheckRefs #186
Summary by CodeRabbit