test(test): guard status filter validation order#222
Open
Lexiie wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughAdded a new test case to ChangesStatus validation regression test
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test list --status junkregression test that runs without credentials.VALIDATION_ERRORbehavior so invalid status filters cannot regress intoAUTH_REQUIREDif validation order changes.Changes
runListcommand-parser path for--statusvalidation before credentials/client setup.Verification
rtk vitest run src/commands/test.test.ts -t "rejects --status=junk before reading credentials"rtk npx eslint src/commands/test.test.ts --fix-dry-run --format stylishrtk npx eslint src/commands/test.test.tsrtk npm run typecheckFixes #210
Summary by CodeRabbit
--statusvalues are rejected immediately when listing tests, with a clear validation error.