Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
cxx_std_17torobin_map's INTERFACE compile features so CMake propagates the library's language requirement to consumers, including installed and build-tree exports.The headers require C++17 facilities such as
std::launderandstd::clamp, but the exported target currently advertises no language requirement. A C++17-capable compiler is therefore invoked as C++14 when the consuming project sets that as its baseline. The existing test executable explicitly requests C++17 and hides the missing requirement.Add a separate consumer target with a C++14 baseline to exercise this during the normal test build. Related: #88 reported the C++17 compilation symptom; this change publishes the existing requirement through the CMake target.
Validation
Locally with GCC 14.2, CMake 3.31.6 and Boost 1.83:
git diff --checkpassesOther compilers/platforms and minimum-CMake execution were not run locally.