Repository navigation
fix(triage): 防止误改含 marker 的用户评论 - #345
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
审查结论:通过。变更将分诊评论识别收敛为 is_triage_comment,同时校验评论作者为 github-actions[bot] 且正文以 triage marker 开头;夜间扫描复用同一判定,可避免用户或其他 bot 粘贴 marker 时误更新评论或误跳过分诊。新增测试覆盖用户评论、其他 bot 评论、正文引用 marker、已有 bot 评论及夜间扫描场景。未发现阻断性的正确性、安全或维护性问题;针对性测试 test_apply_issue_triage_result.py 8 项与 test_nightly_existing_code_review.py 19 项均通过。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-actions[bot]发布、且以 triage marker 开头的评论视为可更新的分诊评论,避免覆盖用户评论。Fixes #344
Testing
PYTHONDONTWRITEBYTECODE=1 .venv/bin/python -m unittest discover -s .github/aicodingflow-tests:542 项通过。git diff --check:通过。Risk
How to revert
49c5307,恢复原有评论匹配逻辑。