Repository navigation
fix: close the local terminal tab when its shell exits - #86
Merged
LukeGus merged 8 commits intoNov 16, 2026
Merged
Conversation
Match SSH sessions: when the local shell exits, close the tab instead of leaving it open with a "Process exited" message.
|
AI review | Looks safe to merge Adds an onClose callback to the local terminal component to automatically close the tab when the shell process exits. The implementation uses a ref to prevent unnecessary re-renders and introduces no security or stability risks. Reviewed 94ff5ab. AI can be wrong, a maintainer still decides. Comment |
# Conflicts: # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the local shell exits (e.g. typing
exit), the Local terminal tab stayed open showingProcess exited (0).SSH sessions close their tab in the same situation.
This passes an
onClosecallback fromLocalTerminalTab(viashell.closeTab) intoLocalTerminal, which calls it on the backendexitframe. The callback is kept in a ref so a new identity doesn't restart the shell.Testing
exitcloses the tab.tscreports no new errors.